Fix colour penalties being bypassed via repeated ratio variance #33641
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will also request a smoogisheet for this one to be extra safe @ppy/pp-maintainers, cheers |
buyaspacecube
suggested changes
Jun 12, 2025
osu.Game.Rulesets.Taiko/Difficulty/Evaluators/ColourEvaluator.cs
Outdated
Show resolved
Hide resolved
osu.Game.Rulesets.Taiko/Difficulty/Evaluators/ColourEvaluator.cs
Outdated
Show resolved
Hide resolved
buyaspacecube
approved these changes
Jun 17, 2025
|
!diffcalc |
stanriders
requested changes
Jul 21, 2025
|
values look right to me |
stanriders
approved these changes
Jul 27, 2025
Lawtrohux
added a commit
to Lawtrohux/osu
that referenced
this pull request
Jul 29, 2025
…33641) * fix a lil bit of colour * review comments * fix empty initialiser
Finadoggie
pushed a commit
to Finadoggie/osu
that referenced
this pull request
Aug 18, 2025
…33641) * fix a lil bit of colour * review comments * fix empty initialiser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the
consistentRatioPenaltylogic to ensure it cannot be bypassed by spamming 'artificial' ratio changes through offsnaps that can still be hit as a normal 1/4 pattern. This was previously found most egregiously in a test map.Essentially, whilst preserving original logic, this adds a fallback penalty that checks recent rhythmic ratios, if they're within a predefined average, these fallback into the original logic. This can in some cases nerf colour patterns even more, as its harshened when there are gaps vs a long, sustained 1/4 pattern.
This results in more accurate and abuse-resistant evaluation, without affecting properly varied rhythmically intense maps.