ensure monolengthbonus applies to new strain contribution only
#33635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ppy/pp-maintainers could i grab a smoogisheet for this please? preferably one with converts-only and without. Thank you! |
buyaspacecube
suggested changes
Jun 11, 2025
buyaspacecube
approved these changes
Jun 11, 2025
tsunyoku
reviewed
Jun 12, 2025
|
!diffcalc |
|
Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/15765452591 |
|
!diffcalc |
stanriders
approved these changes
Jul 21, 2025
|
looks like it! |
Finadoggie
pushed a commit
to Finadoggie/osu
that referenced
this pull request
Aug 18, 2025
…#33635) * stamina fix * review changes * fix naming --------- Co-authored-by: StanR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this PR is correct the application of
monoLengthBonuswithin Stamina.Mainly, the bonus was applied to the accumulated strain, rather than new strain contribution, causing issues on some maps where removing objects can increase SR due to applying the bonus already decayed notes. This effect was not intended, and whilst isn't a huge issue, should see some difficult mono maps rightfully getting a buff, as well as fixing something actually broken.
Similarly, it disables it inside of singlecolourstamina, in which it would skew values that are displaying for mainly convert-esque maps. This also means that convert values should now display correctly true to their intended values.