Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@buyaspacecube
Copy link
Member

@buyaspacecube buyaspacecube commented Jul 13, 2025

These changes replace the formula for accuracy pp, as well as penalise rhythm difficulty from pp based on estimated unstable rate.

More effort has been put in to balance this than my other recent changes. The new curve is steeper than the current (making improving your acc on a play more rewarding) and attempts to break even with the current curve at 98% accuracy on a nomod map of the given star rating, based on estimated UR data from a large number of ranked maps. See said data and how the curves compare here https://www.desmos.com/calculator/hwd2pjmqqr

The rhythm penalty uses the same data but for 100% acc rather than 98% to estimate the unstable rate at which all of a map's rhythm difficulty has been played successfully. 2x this unstable rate is around 90-91% on the same maps which is where I think it's safe to say all rhythm difficulty has been ignored. Rhythm difficulty / star rating has been a good measure of rhythm contribution to a map since #32426, with around 0.15 being where rhythm starts to have any effect on star rating and 0.35 being maps like 3772247 (hard rhythm but mechanically easy) and 4543374 (very hard rhythm). Removing all rhythm strain from these 0.35 maps reduces star rating by ~20%, and doing the same on maps in the middle with 0.25 (such as 3658314 and 4725197) reduces star rating by ~5% which is why I went with 0.2 * rhythmFactor^2 for the penalty's max value.

I also renamed the mono acc scaling stuff for more clarity now that we have two acc related scalings in difficulty pp

Copy link
Member

@Lawtrohux Lawtrohux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things just relating to comments and naming - please also adjust tests.

@buyaspacecube buyaspacecube requested a review from Lawtrohux July 22, 2025 08:45
@buyaspacecube
Copy link
Member Author

@stanriders could i have a sheet on this pls

Copy link
Member

@Lawtrohux Lawtrohux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments are much better, happy with naming too.

@stanriders
Copy link
Member

!diffcalc
RULESET=taiko
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#34188

@github-actions
Copy link

@buyaspacecube
Copy link
Member Author

losses look absolutely right, gains look right even if i can mostly only see easy maps

@buyaspacecube buyaspacecube requested a review from a team July 24, 2025 14:14
@buyaspacecube buyaspacecube moved this from Pending Review to Pending Maintainers Review in Difficulty calculation changes Jul 24, 2025
@Lawtrohux
Copy link
Member

as a forefront - super happy with the sheet, so approval is as stands.

@buyaspacecube
Copy link
Member Author

@stanriders can i have another sheet just in case

@stanriders
Copy link
Member

!diffcalc
RULESET=taiko
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#34188

@stanriders
Copy link
Member

Code quality is failing

@github-actions
Copy link

@buyaspacecube
Copy link
Member Author

new sheet looks absolutely fine

@buyaspacecube
Copy link
Member Author

@Lawtrohux just checking ur still happy with the new implementation and sheet?

@Lawtrohux
Copy link
Member

happy, seems to be more in line with my expectations of the changes

@buyaspacecube buyaspacecube requested a review from stanriders July 29, 2025 13:29
@tsunyoku tsunyoku enabled auto-merge (squash) July 29, 2025 17:39
@tsunyoku tsunyoku merged commit eaaca60 into ppy:pp-dev Jul 29, 2025
3 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Pending Maintainers Review to Pending Deploy in Difficulty calculation changes Jul 29, 2025
@buyaspacecube buyaspacecube deleted the acc-4-merge branch August 2, 2025 11:31
Finadoggie pushed a commit to Finadoggie/osu that referenced this pull request Aug 18, 2025
* New acc curve

* Penalise rhythm difficulty based on unstable rate

* Rename mono acc stuff for more clarity

* Fix nullable

* Rename stuff

* Get actual estimation for SS unstable rate

* Double space my bad

---------

Co-authored-by: James Wilson <[email protected]>
@stanriders stanriders moved this from Pending Deploy to Deployed in Difficulty calculation changes Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Deployed

Development

Successfully merging this pull request may close these issues.

4 participants