Fix messages from blocked users being visible in public channels #35645
+78
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges from public channels
Closes ppy#35633. It appears that the expectation from web here is that messages from blocked users should be excised client-side. Compare: https://github.com/ppy/osu-web/blob/12dd504255bddc0cb37701c392c460222b6825db/resources/js/chat/conversation-view.tsx#L104 This implementation won't *restore* the messages after a block and unblock, but I kind of... don't care if I'm honest with you? Making that happen will result in a bunch of complications for no reason, so I'm fine waiting for anyone to complain about it.
smoogipoo
approved these changes
Nov 7, 2025
This was referenced Nov 21, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #35633.
It appears that the expectation from web here is that messages from blocked users should be excised client-side. Compare website logic.
This implementation won't restore the messages after a block and unblock, but I kind of... don't care if I'm honest with you? Making that happen will result in a bunch of complications for no reason, so I'm fine waiting for anyone to complain about it.