apis/projectcontour: replace kubeconditions.go with apimachinery ref #3159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This has the benefit of addressing the linting failure on |
…chinery Replaces our copy-pasted version of the Condition and related types with the apimachinery version now that it's in a tagged release that Contour uses. Signed-off-by: Steve Kriss <[email protected]>
6a1d6da to
8fb68a9
Compare
Codecov Report
@@ Coverage Diff @@
## main #3159 +/- ##
==========================================
+ Coverage 74.18% 74.21% +0.03%
==========================================
Files 96 96
Lines 6011 6011
==========================================
+ Hits 4459 4461 +2
+ Misses 1455 1454 -1
+ Partials 97 96 -1
|
skriss
added a commit
to skriss/contour
that referenced
this pull request
Nov 30, 2020
…ility PR projectcontour#3159 removed publicly exported types; this PR adds back type aliases to the k8s.io/apimachinery/pkg/apis/meta/v1 Condition types to retain API compatibility. Updates projectcontour#3159. Closes projectcontour#3003. Signed-off-by: Steve Kriss <[email protected]>
skriss
added a commit
to skriss/contour
that referenced
this pull request
Nov 30, 2020
PR projectcontour#3159 removed publicly exported types; this PR adds back type aliases to the k8s.io/apimachinery/pkg/apis/meta/v1 Condition types to retain API compatibility. Updates projectcontour#3159. Closes projectcontour#3003. Signed-off-by: Steve Kriss <[email protected]>
skriss
added a commit
that referenced
this pull request
Nov 30, 2020
…om apimachinery (#3159)" (#3161) This reverts commit e11d4ce. Signed-off-by: Steve Kriss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]