Revert "apis/projectcontour: replace kubeconditions.go with apimachinery ref" #3161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The lint check is going to fail since this file has a non-conformant copyright header. Can add DCO when squashing for merge (the commit was created via GitHub GUI so doesn't have it). |
Codecov Report
@@ Coverage Diff @@
## main #3161 +/- ##
=======================================
Coverage 74.21% 74.21%
=======================================
Files 96 96
Lines 6011 6011
=======================================
Hits 4461 4461
Misses 1454 1454
Partials 96 96
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3159
Reverting this for now since it removed some publicly exported types from the API package which was a breaking API change for consumers of the Go package.