Fix nifti scaling bug when saving qMRI maps #495
Conversation
Only happens if the input files had scale factors set, as their header are used for a template.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 47.40% 47.40%
=======================================
Files 260 260
Lines 8654 8654
=======================================
Hits 4102 4102
Misses 4552 4552
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Thank you @mathieuboudreau, I am glad that we run into this issue! I tested this branch on master and this branch, and forcing these parameters do the trick.
I checked, none of the data I used so far had scaling in the input images. I hope this is rare, but could be an important thing to bring up with BIDS maybe.
* Filter doesn't work on octave, patch it (#483) * Bug fixed : bounds for fitting mono T2 (#488) * Bug fixed : bounds for fitting mono T2 * Fix the -Fix- behaviour * Update mono_t2 full dataset (now ver 3) and partial dataset (now ver 2) on osf --------- Co-authored-by: Mathieu Boudreau <[email protected]> * Fix nifti scaling bug when saving qMRI maps (#495) Only happens if the input files had scale factors set, as their header are used for a template. * Fix isempty bug for doc data download (#496) * Correct excitation flip angles in R1 and A calculations when B1 input exists (#497) * Correct flip angles in R1, A, and MTsat calculations when B1 input exists * Revert inclusion of B1 correction in MTsat(Inds) following discussion & threads (for now, at least) * Factor out B1 multiplications * MP2RAGE: Add magnitude-only data functionality (#498) --------- Co-authored-by: BusraBulut222 <[email protected]>
Fixes a bug where if the input file used as a template has a scaling factor set within the nifti file, the saved nii qMRI map would inherit this scaling factor, causing issues when the nii qMRI map would be loaded in this tool or another tool (due to the scaling being applied).