Merge master into branch #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug fixed : bounds for fitting mono T2 * Fix the -Fix- behaviour * Update mono_t2 full dataset (now ver 3) and partial dataset (now ver 2) on osf --------- Co-authored-by: Mathieu Boudreau <[email protected]>
Only happens if the input files had scale factors set, as their header are used for a template.
… exists (#497) * Correct flip angles in R1, A, and MTsat calculations when B1 input exists * Revert inclusion of B1 correction in MTsat(Inds) following discussion & threads (for now, at least) * Factor out B1 multiplications
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mb/qmt_ismrm #505 +/- ##
================================================
- Coverage 47.40% 47.39% -0.01%
================================================
Files 260 260
Lines 8647 8733 +86
================================================
+ Hits 4099 4139 +40
- Misses 4548 4594 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Describe the problem or feature in addition to a link to the issues.
Approach
How does this change address the problem?
Open Questions and Pre-Merge TODOs
Use github checklists. When solved, check the box and explain the answer.
Review that changed source files/lines are related to the pull request/issue
If any files/commits were accidentally included, cherry-pick them into another branch.
Review that changed source files/lines were not accidentally deleted
Fix appropriately if so.
Test new features or bug fix
If not implemented/resolved adequately, solve it or inform the developer by requesting changes in your review.
Preferably, set breakpoints in the locations that the code was changed and follow allong line by line to see if the code behaves as intended.
Manual GUI tests (general)
Specifications