Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: make all rules errors instead of warnings #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kieckhafer merged 4 commits into from
Jul 12, 2019
Merged

feat: make all rules errors instead of warnings #17

kieckhafer merged 4 commits into from
Jul 12, 2019

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jul 11, 2019 •
edited
Loading

Resolves #5
Resolves #7
Resolves #12
Resolves #13

We have cleaned up our codebase enough where all rules are either clean, or are overridden with a warn instead of a error locally inside of package.json. Changing all rules to error will guarantee no new eslint issues are introduced in the future.

@kieckhafer
feat: change all rules to 'error'
5457459 
Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer
chore: bump version
4812604 
Signed-off-by: Erik Kieckhafer <[email protected]>
This was referenced Jul 11, 2019
Closed
Closed
Closed
Closed
@kieckhafer
chore: update dependency versions
2556d6c 
Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer kieckhafer requested a review from aldeed July 12, 2019 04:56
@kieckhafer
Copy link
Member Author

kieckhafer commented Jul 12, 2019 •
edited
Loading

@aldeed added the node plugin, and updated all the dependencies. reactioncommerce/reaction#5308 has been merged into reaction to override existing issues as warn, so this is good to be merged if it looks OK.

@kieckhafer
Copy link
Member Author

kieckhafer commented Jul 12, 2019 •
edited
Loading

@zenweasel @rosshadden @aldeed don't need all three of you to approve, just whomever gets to it first, but since you all had input just wanted to tag you all.

Once merged, I'll make the release 2.0 from it, then create a PR in Reaction to update to 2.0. The PR that provided warn overrides in Reaction has already been merged, so this should have no effect for our existing rules, I'll probably have to add a warn override for some of the new eslint-plugin-node rules for now, but will do that in the update branch in reaction.

rosshadden
rosshadden approved these changes Jul 12, 2019
View reviewed changes
Copy link

@rosshadden rosshadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First!

@kieckhafer kieckhafer merged commit 152cd20 into master Jul 12, 2019
@rc-publisher
Copy link
Collaborator

rc-publisher commented Jul 12, 2019

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rc-publisher rc-publisher added the released Applied automatically by semantic-release label Jul 12, 2019
@kieckhafer kieckhafer mentioned this pull request Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aldeed aldeed Awaiting requested review from aldeed

@brent-hoover brent-hoover Awaiting requested review from brent-hoover

1 more reviewer

@rosshadden rosshadden rosshadden approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released Applied automatically by semantic-release

Projects

None yet

Milestone

No milestone

4 participants

@kieckhafer @rc-publisher @rosshadden