Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jul 11, 2019

Impact: minor
Type: chore

Issue

There are six remaining eslint rules that output warnings in our code-base. These rules are time consuming to fix (a lot of jsdoc issues), therefore will... take some time.

Instead of going back and forth between this repo and https://github.com/reactioncommerce/reaction-eslint-config and adjusting rules one by one, we are going to:

  1. create a 2.0 release of reaction-eslint-config, which turns all these rules into errors
  2. add overrides (this PR) in the reaction repo for rules still needing audits
  3. update reaction to use reaction-eslint-config 2.0 (a new PR once that release is made)
  4. remove each override as a final step when doing the eslint tickets: https://github.com/reactioncommerce/reaction/projects/16

Breaking changes

None

Testing

  1. make sure the app starts ... Nothing should change, as this just overrides a bit of logic from https://github.com/reactioncommerce/reaction-eslint-config, but the logic overwritten is currently the exact same as what's in the other repo

@kieckhafer kieckhafer merged commit 7e339a5 into develop Jul 12, 2019
@kieckhafer kieckhafer deleted the chore-kieckhafer-addEslintOverridesForRemainingRules branch July 12, 2019 04:31
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants