Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore Update to base image 1.8.0.2 to include Kafka binary libs #4937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brent-hoover merged 2 commits into from
Jan 27, 2019
Merged

chore Update to base image 1.8.0.2 to include Kafka binary libs #4937

brent-hoover merged 2 commits into from
Jan 27, 2019

Conversation

@impactmass
Copy link
Contributor

@impactmass impactmass commented Jan 25, 2019 •
edited
Loading

Type: chore?

Changes

  • We published an updated base image in order to add new dependencies useful for kakfa development ((feat) Add sinek kafka lib binary dependencies base#39). This update is particularly useful for data import features.
  • The base image versioning is currently tied to Meteor versions, hence the new base image for 1.8.0.2
  • Meteor 1.8.0.2 only contains a minor bug fix Release 1.8.0.2 meteor/meteor#10403
  • Meteor's Atmosphere packages also got some patch updates

Testing

  • Run basic tests in the meteor app (guest browsing, add to cart, login, checkout)
  • You can merge this into a branch you're using in development and test it out for a few hours
  • Confirm that the kafka-related bins (librdkafka-dev, libsasl2-dev) are present (@dancastellon I assume you know how to confirm this, since you use them)

@impactmass impactmass force-pushed the chore-impactmass-update-base-image-1.8.0.2 branch from c786fa0 to 358f6da Compare January 25, 2019 15:24
dancastellon
dancastellon approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@dancastellon dancastellon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@impactmass Confirmed! I'm now able to consume Kafka messages in batches, which requires the lib.

@brent-hoover
Copy link
Collaborator

brent-hoover commented Jan 26, 2019

Technically they aren't sinek binaries, they are the Kafka binary libs that would work with any library that wraps the binaries. Sinek is the only one I know of though

brent-hoover
brent-hoover reviewed Jan 26, 2019
View reviewed changes
.meteor/release
@@ -1 +1 @@
[email protected]
[email protected].0.2
Copy link
Collaborator

@brent-hoover brent-hoover Jan 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@impactmass did you intend to upgrade Meteor here?

Copy link
Contributor Author

@impactmass impactmass Jan 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Here's a line from the PR description (with some more emphasis):

The base image versioning is currently tied to Meteor versions, hence the new base image for 1.8.0.2

The versioning plan in the reaction/base repo is that we cut releases with meteor versions. So the binaries needed here are in the new version cut with the updated meteor. Hence this change.

@impactmass impactmass changed the title chore Update to base image 1.8.0.2 to include sinek binaries chore Update to base image 1.8.0.2 to include Kafka binary libs Jan 26, 2019
@impactmass
Copy link
Contributor Author

impactmass commented Jan 26, 2019

Technically they aren't sinek binaries, they are the Kafka binary libs that would work with any library that wraps the binaries. Sinek is the only one I know of though

Thanks, I've updated the copy for correctness.

brent-hoover
brent-hoover approved these changes Jan 27, 2019
View reviewed changes
Copy link
Collaborator

@brent-hoover brent-hoover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@impactmass Thanks for this!

@brent-hoover brent-hoover merged commit 5521fce into develop Jan 27, 2019
@brent-hoover brent-hoover deleted the chore-impactmass-update-base-image-1.8.0.2 branch January 27, 2019 05:43
@jeffcorpuz jeffcorpuz mentioned this pull request Mar 1, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brent-hoover brent-hoover brent-hoover approved these changes

+1 more reviewer

@dancastellon dancastellon dancastellon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@impactmass @brent-hoover @dancastellon