-
Notifications
You must be signed in to change notification settings - Fork 2.2k
chore Update to base image 1.8.0.2 to include Kafka binary libs #4937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brent-hoover
merged 2 commits into
develop
from
chore-impactmass-update-base-image-1.8.0.2
Jan 27, 2019
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,11 +11,11 @@ [email protected] # Packages every Meteor app needs to have | |
| [email protected] # Packages for a great mobile UX | ||
| [email protected] # Compile .html files into Meteor Blaze views | ||
| [email protected] # ECMAScript 5 compatibility for older browsers. | ||
| [email protected].0 # Enable ECMAScript2015+ syntax in app code | ||
| [email protected].4 # Enable ECMAScript2015+ syntax in app code | ||
| [email protected] # ensure meteor method argument validation | ||
| [email protected] # security-related policies enforced by newer browsers | ||
| juliancwirko:[email protected] # CSS post-processing plugin (replaces standard-minifier-css) | ||
| session@1.1.8 # ReactiveDict whose contents are preserved across Hot Code Push | ||
| session@1.2.0 # ReactiveDict whose contents are preserved across Hot Code Push | ||
| [email protected] # Meteor transparent reactive programming library | ||
| [email protected] | ||
| [email protected] | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| [email protected] | ||
| [email protected].0.2 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| ############################################################################## | ||
| # meteor-dev stage - builds image for dev and used with docker-compose.yml | ||
| ############################################################################## | ||
| FROM reactioncommerce/base:v1.8-meteor as meteor-dev | ||
| FROM reactioncommerce/base:v1.8.0.2-meteor as meteor-dev | ||
|
|
||
| LABEL maintainer="Reaction Commerce <[email protected]>" | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@impactmass did you intend to upgrade Meteor here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Here's a line from the PR description (with some more emphasis):
The versioning plan in the
reaction/baserepo is that we cut releases with meteor versions. So the binaries needed here are in the new version cut with the updated meteor. Hence this change.