feat: allow tax services to add custom data to taxes #4955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
aldeed
commented
Feb 1, 2019
| type: Object, | ||
| blackbox: true, | ||
| optional: true | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
This is the only actual change. All other changes were in support of adding the tests.
Contributor
Author
Contributor
|
@aldeed I am testing this. |
Contributor
|
Works! |
Akarshit
approved these changes
Feb 1, 2019
Contributor
|
@aldeed One thing I just discovered is that this only lets me store data per tax item. |
Contributor
Author
|
@Akarshit Would you want to store that on |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4945
Impact: minor
Type: feature
Changes
A tax service's
calculateOrderTaxesfunction may now return a black boxcustomDataobject on each item in thetaxesarrays.This is not exposed through GraphQL. If you need any of the fields, you can create a custom plugin to
extend type CalculatedTaxwith your properly typed custom fields and add resolvers as necessary.Primarily, though, this is intended to be used to store extra data that the third-party tax integrations need for later API calls.
Breaking changes
None
Testing
This isn't currently used in the built-in tax service. You'd have to modify that
calculateOrderTaxesfunction to includecustomDatain its return, and then verify that it's stored in the database.