feat: custom tax data part 2 #4965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and change name to customFields Signed-off-by: Eric Dobbertin <[email protected]>
Contributor
Author
|
@Akarshit Hopefully this should be everything you need |
kieckhafer
approved these changes
Feb 6, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
Looks good.
CircleCI seems to be down, or broken on this repo at the moment. We should wait until that's fixed before merging.
Member
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4945
Resolves #4964
Impact: minor
Type: feature
Issue
#4955 added ability to store custom fields on
taxesarray items, but there is still a need to store item-level and order-level custom tax data.Solution
It now allows
customFieldsobjects on not onlytaxesarray items, but also on each item tax object, and ontaxSummary. Note also that based on discussions since the first PR, the field name has been changed tocustomFieldsrather thancustomData.Breaking changes
The field name has been changed to
customFieldsrather thancustomData. This is only breaking since the previous PR, which has not yet been released.Testing
See #4955 testing instructions