Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FIX: Unable to checkout with taxes #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jamesporl wants to merge 2 commits into from
Closed

FIX: Unable to checkout with taxes #5042

jamesporl wants to merge 2 commits into from

Conversation

@jamesporl
Copy link
Contributor

@jamesporl jamesporl commented Mar 14, 2019 •
edited
Loading

Impact: major
Type: bugfix

Issue

It is currently impossible to checkout because of schema validation issue here:

reaction/imports/plugins/core/orders/server/no-meteor/mutations/placeOrder.js

Line 577 in b7c6c20

OrderSchema.validate(order);

This validation always fails because the required fields here are not provided:

reaction/imports/plugins/core/taxes/lib/extendCoreSchemas.js

Lines 58 to 81 in b7c6c20

OrderItem.extend({
/**
* Custom key/value data that you need to store.
* You'll need to extend GraphQL schemas if you
* want to expose any of this data through the API.
*/
"customTaxFields": {
type: Object,
blackbox: true,
optional: true
},
"isTaxable": Boolean,
"tax": Number,
"taxableAmount": Number,
"taxCode": {
type: String,
optional: true
},
"taxes": {
type: Array,
optional: true
},
"taxes.$": Taxes
});

since the following lines were removed:

reaction/imports/plugins/core/orders/server/util/addTaxesToGroup.js

Lines 30 to 35 in b7c6c20

const updatedItem = {
...item,
tax: itemTax.tax,
taxableAmount: itemTax.taxableAmount,
taxes: itemTax.taxes
};

Also, some fields needed by SE Team to be saved in an order were removed.

Solution

I put back tax data per item and added a blackbox taxData field to invoice schema to allow saving of custom fields returned by tax service in a fulfillment group..

Testing

You should be able to checkout.

@jamesporl jamesporl changed the base branch from master to develop March 14, 2019 08:54
@brent-hoover brent-hoover requested a review from aldeed March 14, 2019 08:57
@nnnnat nnnnat self-requested a review March 14, 2019 14:42
@aldeed
Copy link
Contributor

aldeed commented Mar 14, 2019

@ajporlante There is a simpler fix. I have it in #5018 already, so we can either get that merged or cherry pick fdc1cbf

@aldeed
Copy link
Contributor

aldeed commented Mar 14, 2019

There is an alternative PR here: #5043

I know this fixes the main checkout error I was seeing, but I'll leave this open for now in case there's still some additional issue.

@aldeed aldeed closed this Mar 14, 2019
@machikoyasuda machikoyasuda deleted the ajporlante-fix-unable-to-checkout-with-taxes branch November 5, 2019 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aldeed aldeed Awaiting requested review from aldeed

@nnnnat nnnnat Awaiting requested review from nnnnat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesporl @aldeed @brent-hoover