fix: naming issue caused taxes to not be calculated #5043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Dobbertin <[email protected]>
to fix integration test Signed-off-by: Eric Dobbertin <[email protected]>
nnnnat
approved these changes
Mar 14, 2019
Contributor
nnnnat
left a comment
There was a problem hiding this comment.
👍 Looks good, checkout/order creating seems to be working
Merged
cmbirk
pushed a commit
to cmbirk/reaction
that referenced
this pull request
Aug 18, 2019
…deed-tax-issue fix: naming issue caused taxes to not be calculated
cmbirk
pushed a commit
to cmbirk/reaction
that referenced
this pull request
Aug 18, 2019
Merge pull request reactioncommerce#5043 from reactioncommerce/fix-aldeed-tax-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact: major
Type: bugfix
Issue
Cannot checkout due to total mismatch when there's any tax on an order
Solution
A function was not being found due to having renamed it in one place but not another. Fix the names.
Breaking changes
None
Testing