Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add read-only version of orders 2.0 to break up PR's #5202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aldeed merged 8 commits into from
Jun 10, 2019
Merged

feat: add read-only version of orders 2.0 to break up PR's #5202

aldeed merged 8 commits into from
Jun 10, 2019

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jun 6, 2019 •
edited
Loading

Part of #5157
Impact: major
Type: feature

Issue

The PR #5157, which refactors the Catalyst Orders panel to use all GraphQL, as well as a new design, was getting very big. This PR breaks off a read-only version of the UI, which will help break the review into smaller pieces, as well as meet the need for a read-only version of this to be available for some end to end testing we are trying to do, without waiting on the full functionality, which isn't needed for this testing.

Breaking changes

None. The old Orders UI is still the primary UI, and you need a special URL to access the new Panel.

Testing

  1. Create an order, with multiple items and multiple payments, via the storefront
  2. Break the Items into multiple fulfillment groups using the addOrderFulfillmentGroup mutation ( Add addOrderFulfillmentGroup mutation #5027 )
  3. See that you can see the order in the "Classis" Orders UI by going to the orders page, clicking on the order from the Table.
  4. Change the url from /orders/, to /orders-2.0/, to see the order in the new UI
  5. See that all the data is correct, that the fulfillment groups are broken up

** please note translations for order statuses will not be added by default to a new shop. you can follow instructions here on how to add them, if you wish: #4981
Order_Details_for_order_reference__BpkeapiCwDpKYmJL5

@kieckhafer
add read-only version of orders 2.0 to break up PR's
b061138 
Signed-off-by: Erik Kieckhafer <[email protected]>
(cherry picked from commit f6f2f36)
@kieckhafer kieckhafer marked this pull request as ready for review June 6, 2019 04:17
@kieckhafer kieckhafer requested review from aldeed and mikemurray June 6, 2019 04:26
@kieckhafer
Copy link
Member Author

kieckhafer commented Jun 6, 2019

@mikemurray and I were discussing that instead of just expanding this PR to add order update functionality, it might actually be a good idea to keep these read-only versions of the components, and use them for users with lesser permissions than a full admin.

If we decided to do that, would we want to keep these as separate components completely, and render a fully functional vs. read-only total component? Or would we want to do multiple read-only checks inside each component, and only have one component with the permissions that live inside it?

@aldeed
Copy link
Contributor

aldeed commented Jun 10, 2019

I reviewed and fixed a few things to finish this up for @kieckhafer while he's out. @kieckhafer You may want to look at my commits and make sure those changes are in your subsequent PR for this.

@aldeed aldeed merged commit 968da65 into develop Jun 10, 2019
@aldeed aldeed deleted the feat-kieckhafer-ordersPanel2.0-readOnly branch June 10, 2019 01:17
@aldeed
Copy link
Contributor

aldeed commented Jun 10, 2019

Regarding the question of how best to do read only, I think whatever makes the most sense when doing it would be fine. I would probably default to trying to do checks granularly but if it gets too complicated or messy, fall back to a higher-level entire view only page. Either way the main thing would be to share as much of the smaller specific card components as possible.

@kieckhafer kieckhafer mentioned this pull request Jul 1, 2019
Merged
@jeffcorpuz jeffcorpuz mentioned this pull request Jul 2, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aldeed aldeed aldeed approved these changes

@mikemurray mikemurray Awaiting requested review from mikemurray

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kieckhafer @aldeed