-
Notifications
You must be signed in to change notification settings - Fork 2.2k
refactor: update Reaction Admin Orders panel #5158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update Reaction Admin Orders panel #5158
Conversation
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
…o ref-kieckhafer-ordersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
aldeed
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ all the deletions. Left one comment. Are you sure there aren't some Meteor methods that were only called from the deleted files that could also be deleted from the server?
| template: "OrderInvoice", | ||
| label: "Invoice", | ||
| workflow: "coreOrderShipmentWorkflow", | ||
| audience: ["dashboard/orders"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like OrderInvoice and some of the others here were also deleted. Maybe most if not all of this can go?
|
Outcome of the design review today:
Open questions for the future:
|
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
|
@aldeed removed another batch of files with old meteor methods. I'm not entirely familiar with the layout workflows that are still registered. I think this is ready to go, sans that, maybe we can pair for 15 min and knock that file out before this gets re-reviewed? |
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Resolves #5157
Impact: major
Type: refactor
All of the UI work, queries, mutations and tests have already been reviewed and merged in the PR's listed below. Therefore an in-depth test of all NEW functionality / code here is not the goal of this PR. The goal of this particular PR is to make this new Orders UI the official Orders UI (seen in this Routing change), and to remove the old UI, meteor methods, and related files.
Changes already implemented:
Issue
Operator UI Orders panel currently
Solution
Update the Orders admin to use GraphQL for all data, instead of the existing Meteor methods. In addition, update the panel to preform actions against multiple fulfillment groups, instead of a single combined Order for all groups.
Breaking changes
Meteor methods will no longer work. All orders functionality is now GQL.
Testing
Shopscollection shop object. This will provide translations for all theChipstyle order status badges in the Orders Fulfillment UI.ProductImageworks as it should, as this component was moved out of theOrderspackage and intoCheckoutwhere it's used: 3356ff1/orders/{order-id}, not/orders-beta/{order-id}