-
Notifications
You must be signed in to change notification settings - Fork 2.2k
refactor: fulfillment section of Orders 2.0 #5302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
…ersUiWithMultipleFulfillmentGroups
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
willopez
requested changes
Jul 12, 2019
Member
willopez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes needed.
imports/plugins/core/orders/client/components/OrderCardFulfillmentGroupItem.js
Show resolved
Hide resolved
imports/plugins/core/orders/client/components/OrderCardFulfillmentGroupStatusButton.js
Show resolved
Hide resolved
imports/plugins/core/orders/client/components/OrderCardFulfillmentGroupStatusButton.js
Show resolved
Hide resolved
imports/plugins/core/orders/client/components/OrderCardFulfillmentGroupTrackingNumber.js
Outdated
Show resolved
Hide resolved
imports/plugins/core/orders/client/components/OrderCardFulfillmentGroups.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
willopez
approved these changes
Jul 12, 2019
Member
willopez
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the fulfillment portion of #5157
Impact: major
Type: feature|refactor
Issue
This is one part of a bigger ticket that is refactoring the whole Order Fulfillment UI. You will only be testing the Fulfillment section during this PR, the other pieces have already been tested.
You will be testing:
Cancel orderbutton in the top App BarCancel groupbutton in one or more fulfillment groups.Update group statusbutton in one or more fulfillment groups.Tracking numberfield in one or more fulfillment groups.Breaking changes
None. this is done in the background, on a separate URL, so existing code isn't affected.
Testing
Shopscollection shop object. This will provide translations for all theChipstyle order status badges in the Orders Fulfillment UI./orders/to/orders-beta/to see the new UI.Test the following workflows:
Order fulfillmentpermissions. Test the following with those permission.On an order with multiple fulfillment groups, use the
Cancel orderbutton in the toolbar to cancel all fulfillment groups. Do the same on an order with a single fulfillment group. See that theCancelbutton disappears when an order has already been cancelled.On an order with multiple fulfillment groups, use the
Cancel fulfillment groupbutton individually inside each group to cancel the group. Cancel all the groups this way, and see that the overall order is cancelled once all the individual groups have been cancelled. Do the same on an order with a single fulfillment group. See that theCancelbutton disappears when an order has already been cancelled.On an order with multiple fulfillment groups, add a tracking number on each group and see they update correctly. Then, click the tracking number to edit it, and update the number. See that it updates correctly.
On an order with multiple fulfillment groups, change the
Order statusto various stages, both in the usual order (picked -> packed -> shipped), and also in random orders. Make sure the individual group updates as it should, and no other groups update. Do the same on an order with a single fulfillment group.Change the user permissions so they only have
Order Viewpermissions. See that you can still see the order, but all the buttons are gone and you cannot preform and fulfillment actions.