Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Jul 10, 2019

Fixes the fulfillment portion of #5157
Impact: major
Type: feature|refactor

Issue

This is one part of a bigger ticket that is refactoring the whole Order Fulfillment UI. You will only be testing the Fulfillment section during this PR, the other pieces have already been tested.

Order_Details_for_order_reference__NLuZFydBS6oHLS4Zb

You will be testing:

  1. The Cancel order button in the top App Bar
  2. The Cancel group button in one or more fulfillment groups.
  3. The Update group status button in one or more fulfillment groups.
  4. The Tracking number field in one or more fulfillment groups.

Breaking changes

None. this is done in the background, on a separate URL, so existing code isn't affected.

Testing

  • Add orderStatusLabels to the Shops collection shop object. This will provide translations for all the Chip style order status badges in the Orders Fulfillment UI.
"orderStatusLabels": {
    "new" : [ 
        {
            "language" : "en",
            "label" : "Order received"
        }, 
        {
            "language" : "es",
            "label" : "Recibido"
        }
    ],
    "coreOrderWorkflow/processing" : [ 
        {
            "language" : "en",
            "label" : "Order received"
        }, 
        {
            "language" : "es",
            "label" : "Recibido"
        }
    ],
    "coreOrderWorkflow/completed" : [ 
        {
            "language" : "en",
            "label" : "Shipped"
        }, 
        {
            "language" : "es",
            "label" : "Enviado"
        }
    ],
    "coreOrderWorkflow/canceled" : [ 
        {
            "language" : "en",
            "label" : "Canceled"
        }, 
        {
            "language" : "es",
            "label" : "Cancelado"
        }
    ],
    "coreOrderWorkflow/picked" : [ 
        {
            "language" : "en",
            "label" : "Picked"
        }
    ],
    "coreOrderWorkflow/packed" : [ 
        {
            "language" : "en",
            "label" : "packed"
        }
    ],
    "coreOrderWorkflow/shipped" : [ 
        {
            "language" : "en",
            "label" : "shipped"
        }
    ]
}
  • Create multiple (~5) orders to perform various actions on. Some of these orders should have multiple fulfillment groups (see this PR for instructions on how to create multiple groups). From the Orders table, click on an order to be directed to the single order page. Once there, change the URL from /orders/ to /orders-beta/ to see the new UI.

Reaction

Test the following workflows:

  • Create a new user, add them to the Shop Manager Group, and give the group Order fulfillment permissions. Test the following with those permission.

Accounts

  • On an order with multiple fulfillment groups, use the Cancel order button in the toolbar to cancel all fulfillment groups. Do the same on an order with a single fulfillment group. See that the Cancel button disappears when an order has already been cancelled.

  • On an order with multiple fulfillment groups, use the Cancel fulfillment group button individually inside each group to cancel the group. Cancel all the groups this way, and see that the overall order is cancelled once all the individual groups have been cancelled. Do the same on an order with a single fulfillment group. See that the Cancel button disappears when an order has already been cancelled.

  • On an order with multiple fulfillment groups, add a tracking number on each group and see they update correctly. Then, click the tracking number to edit it, and update the number. See that it updates correctly.

  • On an order with multiple fulfillment groups, change the Order status to various stages, both in the usual order (picked -> packed -> shipped), and also in random orders. Make sure the individual group updates as it should, and no other groups update. Do the same on an order with a single fulfillment group.

  • Change the user permissions so they only have Order View permissions. See that you can still see the order, but all the buttons are gone and you cannot preform and fulfillment actions.

Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
kieckhafer added 17 commits July 9, 2019 22:05
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
@kieckhafer kieckhafer requested a review from willopez July 10, 2019 21:47
@kieckhafer kieckhafer changed the title [WIP] refactor: fulfillment section of Orders 2.0 refactor: fulfillment section of Orders 2.0 Jul 10, 2019
@kieckhafer kieckhafer marked this pull request as ready for review July 10, 2019 21:47
Signed-off-by: Erik Kieckhafer <[email protected]>
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes needed.

Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kieckhafer kieckhafer merged commit d34174d into develop Jul 13, 2019
@kieckhafer kieckhafer deleted the ref-kieckhafer-orderFulfillment branch July 13, 2019 01:35
@kieckhafer kieckhafer mentioned this pull request Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants