-
Notifications
You must be signed in to change notification settings - Fork 2.2k
refactor: refunds section of Orders 2.0 #5405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ersUiWithMultipleFulfillmentGroups
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
…ersUiWithMultipleFulfillmentGroups
…ersUiWithMultipleFulfillmentGroups
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
…ersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
…ery' into ref-kieckhafer-ordersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ery' into ref-kieckhafer-ordersUiWithMultipleFulfillmentGroups
…utation' into ref-kieckhafer-ordersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
…utation' into ref-kieckhafer-ordersUiWithMultipleFulfillmentGroups
…ersUiWithMultipleFulfillmentGroups
…nto ref-kieckhafer-ordersUiWithMultipleFulfillmentGroups
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
|
Other small random things:
|
|
@machikoyasuda Thanks! Fixed 1 & 2.
4 Is a translation issue, and does show capitalized when translations are loaded. I added instructions on how to load translations in the testing part of the PR description. By default it just shows the raw data from the database. We unfortunately do not have a default way of doing this on first load. |
Signed-off-by: Erik Kieckhafer <[email protected]>
|
This could be a ticket for later but OrderStatusChip should inherit from https://catalyst.reactioncommerce.com/#/Components/Content/Chip not MUI Chip. (Just another layer of importing!) and all necessary type changes to OrderStatusChip should come from https://catalyst.reactioncommerce.com/#/Components/Content/Chip |
|
@machikoyasuda Yeah, this PR unfortunately spanned a three week time where we went from MUI 3.x to MUI 4.x, React 16.4 to React 16.8, and Component Library to Catalyst, so there are new ways to do all these things which weren't implemented until after this PR was basically done. #5158 is the final "switch from orders 1.0 to 2.0" ticket, so after this is merged, I am going to do any design updates from @reactioncommerce/design in that tickets, and can also do a lot of these switchovers to using Catalyst instead of MUI directly. |
|
@kieckhafer sounds good! that also.. makes way more sense. this way, we can create individual tickets for all the small tickets and assign them to more people, rather than 1 pr with a zillion little fixes! |
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
|
@aldeed all comments either addressed and fixed, if deemed necessary for this PR, or a ticket created if not required. Ready for another check. |
Signed-off-by: Erik Kieckhafer <[email protected]>
Addresses the refunds portion of #5157
Impact: minor
Type: refactor
Issue
This PR is part of refactoring the Orders Operator UI to deal with multiple fulfillment groups, graphql, etc, to make it 2.0 ready. The majority of the Orders 2.0 UI has already been tested and merged into Reaction.
This PR splits off the refunds portion of the overall work to make it easier to test in smaller chunks. This PR only addresses at the UI portion of refunds - the entirety of the refunds tab. The GraphQL queries and mutations related to refunds have already been tested and merged (#5352, #5354), and don't need to be addressed in this PR.
Breaking changes
None
Testing
Place two orders (six total) of each of the following:
Navigate to the Orders Operator UI
Click on an order, and then once on the single order page, change the URL from
/orders/to/orders-beta/to see the new UI.Once an order is open,
Captureall payments on the order.Then, navigate to the refunds tab. It should look something like this:
At this point, do the following tests:
Then:
Then:
Adding translations for Chips:
Add orderStatusLabels to the Shops collection shop object. This will provide translations for all the Chip style order status badges in the Orders Fulfillment UI.