refactor: remove `catalog/publish/products` meteor method, use `publishProductsToCatalog` GQL Mutation instead #5528

kieckhafer · 2019-09-09T22:56:08Z

Resolves parts of #5529
Impact: minor
Type: refactor

Issue

publishContainer and productGridContainer still use the catalog/publish/products meteor method to publish products, which in turn uses getGraphQLContextInMeteorMethod.

Solution

Re-write anywhere that calls catalog/publish/products to use the publishProuctsToCatalog mutation instead, remove the catalog/publish/products meteor method, which will remove getGraphQLContextInMeteorMethod in this instance.

Breaking changes

Any custom code that uses the catalog/publish/products Meteor method will need to be re-written to use the publishProductsToCatalog graphql mutation

Testing

See the catalog/publish/products meteor method has been removed
Attempt to publish changes to a product to the catalog.
See you are successful

…oducts Signed-off-by: Erik Kieckhafer <[email protected]>

imports/plugins/core/catalog/client/containers/publishContainer.js

imports/plugins/included/product-variant/containers/productGridContainer.js

kieckhafer · 2019-09-11T05:11:34Z

@aldeed updated array destruction

@mikemurray Updated the code to get rid of that weird extra ID thing we were seeing

Signed-off-by: Erik Kieckhafer <[email protected]>

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

Signed-off-by: Mike Murray <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

…on order Signed-off-by: Erik Kieckhafer <[email protected]>

Signed-off-by: Erik Kieckhafer <[email protected]>

… this method Signed-off-by: Erik Kieckhafer <[email protected]> (cherry picked from commit 0e546cf) Signed-off-by: Erik Kieckhafer <[email protected]>

kieckhafer · 2019-09-11T05:57:05Z

Closing in favor of #5541

kieckhafer added 2 commits September 9, 2019 15:39

refactor: use graphql mutation instead of meteor method to publish pr…

eeb2332

…oducts Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: use apollo to call mutation to update products

0ae28ad

kieckhafer changed the title ~~[WIP] Refactor kieckhafer remove context in graph ql catalog publish~~ [WIP] refactor: remove catalog/publish/products meteor method, use publishProductsToCatalog GQL Mutation instead Sep 9, 2019

kieckhafer force-pushed the refactor-kieckhafer-removeContextInGraphQL-catalogPublish branch 2 times, most recently from 50eb8f5 to d651709 Compare September 9, 2019 23:24

aldeed mentioned this pull request Sep 10, 2019

[EPIC] Moving the API off Meteor #4996

Closed

45 tasks

kieckhafer force-pushed the refactor-kieckhafer-removeContextInGraphQL-catalogPublish branch from dc95660 to 96650e9 Compare September 10, 2019 04:19

kieckhafer changed the title ~~[WIP] refactor: remove catalog/publish/products meteor method, use publishProductsToCatalog GQL Mutation instead~~ refactor: remove catalog/publish/products meteor method, use publishProductsToCatalog GQL Mutation instead Sep 10, 2019

kieckhafer requested review from aldeed and mikemurray September 10, 2019 04:21

kieckhafer mentioned this pull request Sep 10, 2019

Rewrite any code which calls getGraphQLContextInMeteorMethod to not use Meteor methods #5529

Closed

12 tasks

aldeed requested changes Sep 10, 2019

View reviewed changes

imports/plugins/core/catalog/client/containers/publishContainer.js Outdated Show resolved Hide resolved

imports/plugins/included/product-variant/containers/productGridContainer.js Outdated Show resolved Hide resolved

kieckhafer and others added 17 commits September 10, 2019 22:41

refactor: remove publishProducts meteor method

a2e80d2

Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: use apollo to call mutation to update products

d62a5fb

Signed-off-by: Erik Kieckhafer <[email protected]>

Update productGridContainer.js

aab39bd

Signed-off-by: Erik Kieckhafer <[email protected]>

Update publishContainer.js

1ff1c5b

Signed-off-by: Erik Kieckhafer <[email protected]>

feat: make image saving work without Meteor

7c355f2

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

fix: adjust tag hero media mutation for raw collection

623af02

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

chore: delete unused MediaGallery component

255bb6f

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

fix: remove invalid table padding prop

9f38e9d

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

chore: delete unused importSettings template

52dfc63

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

fix: update shop brand image remove for no-Meteor

3bd7572

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

feat: use MediaUploader for product media

f7c57a9

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

feat: combine logo sections on shop settings page

ebd763f

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

fix: archive media for products rather than delete

ee04e1c

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

chore: add deprecation notice on withPrimaryShop HOC

8ea6901

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

chore: reorg import statements

4754e1d

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

fix: don't import Meteor code in non-Meteor app

3795350

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

chore: fix jest integration tests

24c0cbe

Signed-off-by: Eric Dobbertin <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

mikemurray and others added 25 commits September 10, 2019 22:42

feat: add orders connection type resolver

facaabd

Signed-off-by: Mike Murray <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

feat: add offset pagination param

b16ce28

Signed-off-by: Mike Murray <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: move filter by file into its own component

5b710db

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

feature: Add tag multi selector to products page

e71633d

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: wire up add/remove tags mutation to UI

6abc1c4

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: wire up chip delete handler

23c8480

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

chore: upgrade to react-select v3

0b61d3d

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

fix: close bulk actions menu after selection

005f075

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

feature: wire up add/removing tags UI with backend

11afb73

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: resolve various styling issues

5c50943

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

fix: failing tests

ab5075c

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: use number without units in style definitions

c7bbdc4

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

fix: add missing translation

b1268bf

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: various minor CSS updates.

5a04b41

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: use spacing values from theme

8ead9cf

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: remove unnecessary style defitions

6373086

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: consolidate container divs

1521179

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: minor clean up tasks

d19052b

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

chore: use latest version of Reaction Catalyst package

8d4acf6

Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: use moments calendar format to display time alongside date …

cd21250

…on order Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: reformat date

3c0214b

Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: always show date and time

6f9af29

Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: move alert out of JSX return to get rid of odd extra data

8c9db5f

Signed-off-by: Erik Kieckhafer <[email protected]>

chore: update package-lock.json

09193c0

Signed-off-by: Erik Kieckhafer <[email protected]>

refactor: remove accounts/inviteShopOwner tests, as we are removing…

d38c70f

… this method Signed-off-by: Erik Kieckhafer <[email protected]> (cherry picked from commit 0e546cf) Signed-off-by: Erik Kieckhafer <[email protected]>

kieckhafer force-pushed the refactor-kieckhafer-removeContextInGraphQL-catalogPublish branch from c3050cb to d38c70f Compare September 11, 2019 05:45

kieckhafer mentioned this pull request Sep 11, 2019

refactor: remove catalog/publish/products meteor method, use publishProductsToCatalog GQL Mutation instead #5541

Merged

kieckhafer closed this Sep 11, 2019

kieckhafer deleted the refactor-kieckhafer-removeContextInGraphQL-catalogPublish branch October 3, 2019 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: remove `catalog/publish/products` meteor method, use `publishProductsToCatalog` GQL Mutation instead #5528

refactor: remove `catalog/publish/products` meteor method, use `publishProductsToCatalog` GQL Mutation instead #5528

Uh oh!

kieckhafer commented Sep 9, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

kieckhafer commented Sep 11, 2019

Uh oh!

kieckhafer commented Sep 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

refactor: remove catalog/publish/products meteor method, use publishProductsToCatalog GQL Mutation instead #5528

refactor: remove catalog/publish/products meteor method, use publishProductsToCatalog GQL Mutation instead #5528

Uh oh!

Conversation

kieckhafer commented Sep 9, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue

Solution

Breaking changes

Testing

Uh oh!

Uh oh!

Uh oh!

kieckhafer commented Sep 11, 2019

Uh oh!

kieckhafer commented Sep 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

refactor: remove `catalog/publish/products` meteor method, use `publishProductsToCatalog` GQL Mutation instead #5528

refactor: remove `catalog/publish/products` meteor method, use `publishProductsToCatalog` GQL Mutation instead #5528

kieckhafer commented Sep 9, 2019 •

edited

Loading