Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: add create/update/delete navigation item integration tests #5890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
willopez merged 11 commits into from
Dec 16, 2019
Merged

test: add create/update/delete navigation item integration tests #5890

willopez merged 11 commits into from
Dec 16, 2019

Conversation

@mikemurray
Copy link
Member

@mikemurray mikemurray commented Dec 11, 2019

Resolves #5886
Impact: major
Type: bugfix|test

Issue

Missing tests for:

  • createNavigationItem
  • updateNavigationItem
  • deleteNavigationItem
  • incorrect id field passed to mongo update/query in updateNavigationItem mutation

Solution

  • Add the missing tests
  • Fix a bug found in the updateNavigationItem mutation that prevented updates from taking place

Breaking changes

none

Testing

  1. Tests should pass on CI

@mikemurray
fix: use correct id key for mongo operations
145b224 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add create navigation item mutation definition
ae7d495 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add delete navigation item mutation definition
f7c3250 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add update navigation item mutation definition
780acd7 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add create navigation item mutation test
a1a70ec 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add delete navigation item mutation test
0fae413 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add update navigation item mutation test
a7bec94 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add create navigation item mutation test snapshot
8ac6a17 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add delete navigation item mutation test snapshot
e76c77c 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray
test: add update navigation item mutation test snapshot
0645746 
Signed-off-by: Mike Murray <[email protected]>
@mikemurray mikemurray requested a review from willopez December 11, 2019 00:56
willopez
willopez approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@willopez willopez merged commit ae1baf6 into release-3.0.0 Dec 16, 2019
@willopez willopez deleted the test-5886-mikemurray-create-nav-item branch December 16, 2019 18:56
@kieckhafer kieckhafer mentioned this pull request Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@willopez willopez willopez approved these changes

+1 more reviewer

@trojanh trojanh trojanh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mikemurray @willopez @trojanh