reactioncommerce · willopez · Dec 16, 2019 · Dec 11, 2019 · Dec 11, 2019 · Dec 11, 2019
diff --git a/src/plugins/navigation/mutations/updateNavigationItem.js b/src/plugins/navigation/mutations/updateNavigationItem.js
@@ -46,9 +46,9 @@ export default async function updateNavigationItem(context, input) {
     }
   }
 
-  await NavigationItems.updateOne({ navigationItemId }, { $set: { ...update } });
+  await NavigationItems.updateOne({ _id: navigationItemId }, { $set: { ...update } });
 
-  const updatedNavigationItem = await NavigationItems.findOne({ navigationItemId });
+  const updatedNavigationItem = await NavigationItems.findOne({ _id: navigationItemId });
 
   return updatedNavigationItem;
 }
diff --git a/tests/integration/api/mutations/navigationItem/CreateNavigationItemMutation.graphql b/tests/integration/api/mutations/navigationItem/CreateNavigationItemMutation.graphql
@@ -0,0 +1,35 @@
+mutation CreateNavigationItem($createNavigationItemInput: CreateNavigationItemInput!) {
+	createNavigationItem(input: $createNavigationItemInput) {
+    navigationItem {
+      ...NavigationItem
+    }
+  }
+}
+
+fragment NavigationItem on NavigationItem {
+  _id
+  data {
+		contentForLanguage
+    content {
+      language
+      value
+    }
+    url
+    isUrlRelative
+    shouldOpenInNewWindow
+  }
+  draftData {
+    classNames
+    content {
+      language
+      value
+    }
+    contentForLanguage
+    isUrlRelative
+    shouldOpenInNewWindow
+    url
+  }
+  metadata
+  createdAt
+  hasUnpublishedChanges
+}
diff --git a/tests/integration/api/mutations/navigationItem/DeleteNavigationItemMutation.graphql b/tests/integration/api/mutations/navigationItem/DeleteNavigationItemMutation.graphql
@@ -0,0 +1,38 @@
+mutation DeleteNavigatonItem($id: ID!, $shopId: ID!) {
+	deleteNavigationItem(input: {
+    id: $id,
+    shopId: $shopId
+  }) {
+    navigationItem {
+      ...NavigationItem
+    }
+  }
+}
+
+fragment NavigationItem on NavigationItem {
+  _id
+  data {
+		contentForLanguage
+    content {
+      language
+      value
+    }
+    url
+    isUrlRelative
+    shouldOpenInNewWindow
+  }
+  draftData {
+    classNames
+    content {
+      language
+      value
+    }
+    contentForLanguage
+    isUrlRelative
+    shouldOpenInNewWindow
+    url
+  }
+  metadata
+  createdAt
+  hasUnpublishedChanges
+}
diff --git a/tests/integration/api/mutations/navigationItem/UpdateNavigationItemMutation.graphql b/tests/integration/api/mutations/navigationItem/UpdateNavigationItemMutation.graphql
@@ -0,0 +1,35 @@
+mutation UpdateNavigatonItem($updateNavigationItemInput: UpdateNavigationItemInput!) {
+	updateNavigationItem(input: $updateNavigationItemInput) {
+    navigationItem {
+      ...NavigationItem
+    }
+  }
+}
+
+fragment NavigationItem on NavigationItem {
+  _id
+  data {
+		contentForLanguage
+    content {
+      language
+      value
+    }
+    url
+    isUrlRelative
+    shouldOpenInNewWindow
+  }
+  draftData {
+    classNames
+    content {
+      language
+      value
+    }
+    contentForLanguage
+    isUrlRelative
+    shouldOpenInNewWindow
+    url
+  }
+  metadata
+  createdAt
+  hasUnpublishedChanges
+}
diff --git a/.../integration/api/mutations/navigationItem/__snapshots__/createNavigationItem.test.js.snap b/.../integration/api/mutations/navigationItem/__snapshots__/createNavigationItem.test.js.snap
@@ -0,0 +1,28 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`an unauthorized user cannot create a navigation item 1`] = `
+Array [
+  Object {
+    "extensions": Object {
+      "code": "FORBIDDEN",
+      "exception": Object {
+        "details": Object {},
+        "error": "access-denied",
+        "eventData": Object {},
+        "isClientSafe": true,
+        "reason": "Access Denied",
+      },
+    },
+    "locations": Array [
+      Object {
+        "column": 3,
+        "line": 2,
+      },
+    ],
+    "message": "Access Denied",
+    "path": Array [
+      "createNavigationItem",
+    ],
+  },
+]
+`;
diff --git a/.../integration/api/mutations/navigationItem/__snapshots__/deleteNavigationItem.test.js.snap b/.../integration/api/mutations/navigationItem/__snapshots__/deleteNavigationItem.test.js.snap
@@ -0,0 +1,28 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`an unauthorized user cannot delete a navigation item 1`] = `
+Array [
+  Object {
+    "extensions": Object {
+      "code": "FORBIDDEN",
+      "exception": Object {
+        "details": Object {},
+        "error": "access-denied",
+        "eventData": Object {},
+        "isClientSafe": true,
+        "reason": "Access Denied",
+      },
+    },
+    "locations": Array [
+      Object {
+        "column": 3,
+        "line": 2,
+      },
+    ],
+    "message": "Access Denied",
+    "path": Array [
+      "deleteNavigationItem",
+    ],
+  },
+]
+`;
diff --git a/.../integration/api/mutations/navigationItem/__snapshots__/updateNavigationItem.test.js.snap b/.../integration/api/mutations/navigationItem/__snapshots__/updateNavigationItem.test.js.snap
@@ -0,0 +1,28 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`an unauthorized user cannot update a navigation item 1`] = `
+Array [
+  Object {
+    "extensions": Object {
+      "code": "FORBIDDEN",
+      "exception": Object {
+        "details": Object {},
+        "error": "access-denied",
+        "eventData": Object {},
+        "isClientSafe": true,
+        "reason": "Access Denied",
+      },
+    },
+    "locations": Array [
+      Object {
+        "column": 3,
+        "line": 2,
+      },
+    ],
+    "message": "Access Denied",
+    "path": Array [
+      "updateNavigationItem",
+    ],
+  },
+]
+`;
diff --git a/tests/integration/api/mutations/navigationItem/createNavigationItem.test.js b/tests/integration/api/mutations/navigationItem/createNavigationItem.test.js
@@ -0,0 +1,102 @@
+import importAsString from "@reactioncommerce/api-utils/importAsString.js";
+import Factory from "/tests/util/factory.js";
+import TestApp from "/tests/util/TestApp.js";
+
+const CreateNavigationItemMutation = importAsString("./CreateNavigationItemMutation.graphql");
+
+jest.setTimeout(300000);
+
+const internalShopId = "123";
+const opaqueShopId = "cmVhY3Rpb24vc2hvcDoxMjM="; // reaction/shop:123
+const shopName = "Test Shop";
+
+const mockAdminAccount = Factory.Account.makeOne({
+  roles: {
+    [internalShopId]: ["admin", "core"]
+  }
+});
+
+let testApp;
+let createNavigationItem;
+
+beforeAll(async () => {
+  testApp = new TestApp();
+  await testApp.start();
+  await testApp.insertPrimaryShop({ _id: internalShopId, name: shopName });
+  await testApp.createUserAndAccount(mockAdminAccount);
+
+  createNavigationItem = testApp.mutate(CreateNavigationItemMutation);
+});
+
+afterAll(async () => {
+  await testApp.collections.NavigationItems.deleteMany({});
+  await testApp.collections.Shops.deleteMany({});
+  await testApp.stop();
+});
+
+afterEach(async () => {
+  await testApp.clearLoggedInUser();
+});
+
+test("an unauthorized user cannot create a navigation item", async () => {
+  try {
+    await createNavigationItem({
+      createNavigationItemInput: {
+        navigationItem: {
+          shopId: opaqueShopId,
+          draftData: {
+            classNames: "red-tag",
+            content: [{
+              language: "en",
+              value: "Shirts"
+            }],
+            isUrlRelative: true,
+            shouldOpenInNewWindow: false,
+            url: "/tag/shirts"
+          }
+        }
+      }
+    });
+  } catch (error) {
+    expect(error).toMatchSnapshot();
+  }
+});
+
+test("an authorized user can create a navigation item", async () => {
+  await testApp.setLoggedInUser(mockAdminAccount);
+  let result;
+
+  try {
+    result = await createNavigationItem({
+      createNavigationItemInput: {
+        navigationItem: {
+          shopId: opaqueShopId,
+          draftData: {
+            classNames: "red-tag",
+            content: [{
+              language: "en",
+              value: "Shirts"
+            }],
+            isUrlRelative: true,
+            shouldOpenInNewWindow: false,
+            url: "/tag/shirts"
+          }
+        }
+      }
+    });
+  } catch (error) {
+    expect(error).toBeUndefined();
+  }
+
+  expect(result.createNavigationItem.navigationItem.draftData).toEqual({
+    classNames: "red-tag",
+    content: [{
+      language: "en",
+      value: "Shirts"
+    }],
+    contentForLanguage: null,
+    isUrlRelative: true,
+    shouldOpenInNewWindow: false,
+    url: "/tag/shirts"
+  });
+});