Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kieckhafer
Copy link
Member

@kieckhafer kieckhafer commented Dec 18, 2019

Impact: critical
Type: bugfix

You need to be this branch of Example Storefront when testing. That PR and this one should be merged at the same time.

Issue

Account login was not working when trying to login via example storefront.

Solution

Add oauth login method to new AuthContainer. This is how we used to do oauth login in the past, when we used OauthContainer, but this was removed / with the new AuthContainer.

Breaking changes

None

Testing

  1. Start the full app (reaction / storefront (PR fix: login from storefront example-storefront#633)
  2. Navigate to storefront
  3. Login
  4. See you are redirected back to storefront, and you are logged in
  5. Logout
  6. See you are redirected back to storefront, and are logged out

Signed-off-by: Erik Kieckhafer <[email protected]>
…tioncommerce/reaction into fix-kieckhafer-loginFromStorefront
Copy link
Member

@manueldelreal manueldelreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rosshadden rosshadden merged commit f8ba368 into release-2.9.1 Dec 19, 2019
@rosshadden rosshadden deleted the fix-kieckhafer-loginFromStorefront branch December 19, 2019 20:48
@rosshadden rosshadden mentioned this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants