-
Notifications
You must be signed in to change notification settings - Fork 2.2k
release v2.9.1 #5973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
release v2.9.1 #5973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maria Paktiti <[email protected]>
fix: upgrade handlebars version
fix: upgrade handlebars version Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Ross Hadden <[email protected]>
fix: made bin/setup always run from the desired path
Signed-off-by: Erik Kieckhafer <[email protected]>
a6c80d6 to
48a63c2
Compare
kieckhafer
previously approved these changes
Dec 19, 2019
Member
kieckhafer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, once DCO issue is resolved
cce148f to
48149f4
Compare
This reverts commit cd3ea0b. Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Mike Murray <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Will Lopez <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Ross Hadden <[email protected]>
This reverts commit cd3ea0b. Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]> Signed-off-by: Ross Hadden <[email protected]>
48149f4 to
a7f72cb
Compare
Contributor
Author
|
Fixed DCO. It was failed because of the commit Github made for the revert. |
Signed-off-by: Erik Kieckhafer <[email protected]>
…Showing refactor: use better cache policy to show newly created tags
Signed-off-by: Manuel Del Real <[email protected]>
Signed-off-by: Manuel Del Real <[email protected]>
Signed-off-by: Manuel Del Real <[email protected]>
Fix cart total calculation when shipping includes handling fee
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
… into release-2.9.1
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
…ngHandling Revert "Fix cart total calculation when shipping includes handling fee"
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Erik Kieckhafer <[email protected]>
Signed-off-by: Eric Dobbertin <[email protected]>
…gHandlingNumbers fix: remove extra `handling` charge from fulfillment total
manueldelreal
approved these changes
Dec 23, 2019
Member
manueldelreal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.9.1
Reaction v2.9.1 adds miscellaneous bug fixes and contains no breaking changes since v2.9.0.
This release is being coordinated with
reaction-platformand is designed to work withv2.9.1ofexample-storefrontandreaction-hydra.Notable changes
Fix example-storefront login issue
Logging in from the example storefront has been fixed to allow a user to stay logged in when navigating to login from the storefront.
Fix cart total calculation
Cart total calculation has been fixed to correctly add rate + handling numbers.
Fixes
refactors