Thanks to visit codestin.com
Credit goes to github.com

Skip to content

added RefitRestServiceAttribute for HttpClient relative path #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
clairernovotny merged 3 commits into from
Jun 5, 2019
Merged

added RefitRestServiceAttribute for HttpClient relative path #663

clairernovotny merged 3 commits into from
Jun 5, 2019

Conversation

@yuri-voloshyn
Copy link
Contributor

@yuri-voloshyn yuri-voloshyn commented May 15, 2019

added RefitRestServiceAttribute for HttpClient relative path
fixed issue #662

yuri-voloshyn and others added 2 commits May 15, 2019 17:20
@yuri-voloshyn
Merge pull request #2 from reactiveui/master
a1146b3 
Update
@yuri-voloshyn
fixed issue reactiveui#662
cd8975a 
added RefitRestServiceAttribute for HttpClient relative path
clairernovotny
clairernovotny reviewed May 15, 2019
View reviewed changes
@pit-hub
Copy link

pit-hub commented May 24, 2019 •
edited by unfurl-links bot
Loading

Hi! I've made some improvements to the work of @yuri-voloshyn.
The idea is not to modify the BaseAddress of the HttpClient. Modifying the BaseAddress may leads to unexpected behaviour by developers and also prevent reusing a HttpClient for multiple interfaces, as each instance of HttpClient uses its own pool of sockets.
Can push to the @yuri-voloshyn fork to update the PR.
The code is at: https://github.com/pit-hub/refit/tree/feature/refit-rest-service-attribute

GitHub
The automatic type-safe REST library for Xamarin and .NET - pit-hub/refit

@pit-hub pit-hub mentioned this pull request Jun 5, 2019
Closed
@clairernovotny clairernovotny merged commit 76f03d3 into reactiveui:master Jun 5, 2019
@clairernovotny clairernovotny mentioned this pull request Jun 5, 2019
Merged
@clairernovotny
Copy link
Member

clairernovotny commented Jun 5, 2019

Sorry, merged this by mistake. @pit-hub can you please open a PR with the combined changes?

@pit-hub pit-hub mentioned this pull request Jun 6, 2019
Closed
2 tasks
@lock lock bot locked and limited conversation to collaborators Sep 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@clairernovotny clairernovotny clairernovotny left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yuri-voloshyn @pit-hub @clairernovotny