stage1-implementors-guide.md: Add filesystem layout assumptions. #1832
Conversation
There was a problem hiding this comment.
Sentence per line for now please
4f23114 to
55fa44c
Compare
There was a problem hiding this comment.
This is actually created by stage0:
- Overlay: run.go:556
- Non-overlay: run.go:525
There was a problem hiding this comment.
@iaguis: So it looks like I can drop the creation of the /opt/stage2 directory tree from the build system, right?
There was a problem hiding this comment.
Actually, we probably still have to write something about /opt/stage2 directories being created by rkt, so stage1 implementation shouldn't have any file named stage2 in /opt directory. Or something like that.
There was a problem hiding this comment.
@iaguis @krnowak OK, then can we create /rkt/status /rkt/env in stage0 as well?
The error @steveej got is from
https://github.com/coreos/rkt/blob/master/stage0/run.go#L641
Seems it's because /rkt directory does not exist.
|
Small nit and needs a rebase. |
3123b95 to
fdbb8ca
Compare
fdbb8ca to
7db2519
Compare
7db2519 to
e8b8aa0
Compare
e8b8aa0 to
e9b53fa
Compare
|
@alban Addressed comments. |
There was a problem hiding this comment.
"the environment" or "environment variables"
There was a problem hiding this comment.
s/will/can/
s/fetch/retrieved/
trailing full-stop
|
A few comments, LGTM after that. |
e7ac594 to
dcfa4bf
Compare
|
@jonboulle Thanks! Fixed ! |
There was a problem hiding this comment.
@yifan-gu sorry my comment here seems to have been lost. I'm a little wary of the word "Users" as I don't want to mislead anyone - I suggest a slight tweak:
When creating a stage1 image, developers SHOULD NOT create or use these paths in the image's filesystem
I didn't follow this one @joshix |
dcfa4bf to
16cf215
Compare
|
@joshix Fixed other comments. Replace stage1 with stage 1 in the paragraph. Add $state(run/prepare) in the path. |
|
@yifan-gu I was suggesting that you number your list as 1, 2, 3, 4 (index 1), rather than starting with 0. Notice that the markdown 0, 1, 2, 3, will be rendered as a list beginning with 1 in the HTML presentation. See below:
|
16cf215 to
2978db3
Compare
|
@joshix Gotcha, fixed. |
Also replace " with ` for more clearness.
2978db3 to
e47a27b
Compare
|
LGTM |
stage1-implementors-guide.md: Add filesystem layout assumptions.
cc @steveej @jonboulle @alban @iaguis