Rename alljoints-inertials port to avoid using portprefix #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
approved these changes
Jul 18, 2024
|
cc @S-Dafarra |
pattacini
requested changes
Jul 18, 2024
iCubShenzhen01/wrappers/inertials/alljoints-inertials_wrapper.xml
Outdated
Show resolved
Hide resolved
pattacini
approved these changes
Jul 18, 2024
|
Thanks heaps @pattacini! |
fils99
pushed a commit
to ami-iit/robots-configuration
that referenced
this pull request
Sep 25, 2024
…#669) Co-authored-by: Ugo Pattacini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With:
I added the possibility of reading the Euler angles streamed by the IMUs wrapped up in a single port. I named the port as
/${portprefix}/alljoints/inertialsfollowing what I've done and tested in simulation. Unfortunately, while working on the real robot, I found that theportprefixis not always defined in the configuration files and, if defined, is not alwaysicuborergocub. For example, onergoCubSN000, that port is named/ergoCubSN000/alljoints/inertials.This PR introduces the fix to have all the port names. I also made the change for the iCubs that expose those measurements.