Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@romanzipp
Copy link
Owner

@romanzipp romanzipp commented Nov 19, 2020

This PR includes various changes which will require a new major release.

Changes

  • Drop support for PHP 7.2 (end of life 30 Nov 2020) not needed
  • Drop support for guzzle/http 6.3
  • Remove cache driver configuration key Remove unnecessary cache driver #72
  • Move romanzipp\Twitch\Helpers\Paginator to romanzipp\Twitch\Objects\Paginator

New Endpoints

Exceptions

  • Remove romanzipp\Twitch\Exceptions\RequestRequiresClientIdException
  • Remove romanzipp\Twitch\Exceptions\RequestRequiresClientSecretException
  • Remove romanzipp\Twitch\Exceptions\RequestRequiresRedirectUriException
  • Add romanzipp\Twitch\Exceptions\RequestRequiresAuthenticationException

Result class

All previously public properties are now declared as private. Corresponding getter methods have been added.

  • Rename romanzipp\Twitch\Result to romanzipp\Twitch\Response
  • Dont pass the twitch service instance to response instance

Properties

  • Remove romanzipp\Twitch\Result::$success property
  • Change romanzipp\Twitch\Result::$exception visibility from public to private
  • Change romanzipp\Twitch\Result::$data visibility from public to private
  • Change romanzipp\Twitch\Result::$total visibility from public to private
  • Change romanzipp\Twitch\Result::$status visibility from public to private
  • Change romanzipp\Twitch\Result::$pagination visibility from public to private

Methods

  • Change romanzipp\Twitch\Result::status() method name to getStatus()
  • Change romanzipp\Twitch\Result::error() method name to getErrorMessage()
  • Change romanzipp\Twitch\Result::rateLimit() method name to getRateLimit()
  • Add romanzipp\Twitch\Result::getException() method
  • Add romanzipp\Twitch\Result::getTotal() method
  • Add romanzipp\Twitch\Result::getPagination() method
  • Add romanzipp\Twitch\Result::getPaginator() method

@romanzipp romanzipp marked this pull request as ready for review January 11, 2021 07:28
@romanzipp romanzipp merged commit 9c6b52e into master Jan 11, 2021
@romanzipp romanzipp deleted the next branch January 11, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants