Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary cache driver #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

Remove unnecessary cache driver #72

merged 1 commit into from
Nov 19, 2020

Conversation

@ghostzero
Copy link
Contributor

@ghostzero ghostzero commented Nov 18, 2020 •
edited by romanzipp
Loading

Fixes #70

The laravel cache driver calls the same method within the cache manager:

So the cache driver is redundant. To my knowledge it is not a breaking change.

/**
 * Get a cache driver instance.
 *
 * @param  string|null  $driver
 * @return \Illuminate\Contracts\Cache\Repository
 */
public function driver($driver = null)
{
    return $this->store($driver);
}

@ghostzero ghostzero mentioned this pull request Nov 18, 2020
Closed
@romanzipp romanzipp changed the base branch from master to next November 19, 2020 05:47
@romanzipp romanzipp merged commit 7c8833a into romanzipp:next Nov 19, 2020
@romanzipp
Copy link
Owner

romanzipp commented Nov 19, 2020

Thanks!

@romanzipp romanzipp mentioned this pull request Jan 6, 2021
Merged
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ghostzero @romanzipp