Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@theambient
Copy link
Contributor

by setting work horse process group and killing the whole group.
might be useful if task runs other subprocesses.

…work horse process group and killing this group
@theambient
Copy link
Contributor Author

Where can I find out failed test (all tests) logs so that I can find out what failed ? in my local env (mac) all tests are passed (and some of them are skipped)

@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1348 into master will decrease coverage by 0.10%.
The diff coverage is 73.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
- Coverage   94.98%   94.87%   -0.11%     
==========================================
  Files          41       41              
  Lines        5599     5624      +25     
==========================================
+ Hits         5318     5336      +18     
- Misses        281      288       +7     
Impacted Files Coverage Δ
tests/fixtures.py 64.60% <33.33%> (-2.71%) ⬇️
rq/worker.py 87.14% <66.66%> (-0.14%) ⬇️
rq/utils.py 92.96% <100.00%> (ø)
rq/version.py 100.00% <100.00%> (ø)
tests/test_worker.py 97.34% <100.00%> (+0.03%) ⬆️
rq/cli/helpers.py 86.36% <0.00%> (ø)
tests/test_scheduler.py 98.56% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6f153e...f72a783. Read the comment docs.

@selwin
Copy link
Collaborator

selwin commented Oct 18, 2020

You can see the failing checks here, in this case it’s codecov that breaks. I wouldn’t worry about this one since codecov doesn’t properly track codes run by the work horse.

898900D6-D200-4653-BC40-5D88DBDFAD21

Would it be hard to create a test that simulates a job that creates other subprocesses and check whether all of them are killed along with the horse?

@theambient
Copy link
Contributor Author

@selwin sure, i will make such test

@selwin selwin merged commit 9adcd7e into rq:master Oct 19, 2020
@selwin
Copy link
Collaborator

selwin commented Oct 19, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants