Don't use os.setsid() after forking workhorse
#1970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1970 +/- ##
=======================================
Coverage 93.61% 93.61%
=======================================
Files 28 28
Lines 3757 3757
=======================================
Hits 3517 3517
Misses 240 240
☔ View full report in Codecov by Sentry. |
In 9adcd7e a change was made to make the workhorse process into a session leader. This appears to have been done in order to set the process group ID of the workhorse so that it can be killed easily along with its descendants when `Worker.kill_horse()` is called. However, `setsid` is overkill for this purpose; it sets not only the process group ID but also the session ID. This can cause issues for user jobs which may rely on session IDs being less-than-unique for arbitrary reasons. This change switches to `setpgrp`; this sets the process group ID so that the workhorse and its descendants can be killed *without* changing the session ID.
b4fa9cf to
143baa2
Compare
Collaborator
Contributor
Author
|
no -
|
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 9adcd7e a change was made to make the workhorse process into a session leader. This appears to have been done in order to set the process group ID of the workhorse so that it can be killed easily along with its descendants when
Worker.kill_horse()is called.However,
setsidis overkill for this purpose; it sets not only the process group ID but also the session ID. This can cause issues for user jobs which may rely on session IDs being less-than-unique for arbitrary reasons.This change switches to
setpgrp; this sets the process group ID so that the workhorse and its descendants can be killed without changing the session ID.