Merged
Conversation
cpsievert
commented
May 2, 2024
… trusted to show them when animated
…can't be trusted to show them when animated" This reverts commit 6167c1d.
…ns into a singular busyIndicatorOptions()
1 task
gadenbuie
approved these changes
May 8, 2024
Member
gadenbuie
left a comment
There was a problem hiding this comment.
Excellent PR! This review is all mostly small stuff and only from reading through the code. I'm looking forward to playing with this, but feel confident we can easily address follow up issues as they arise.
One more small note: I do think we should follow up relatively quickly with an alternate spinner option as well as a clear path for providing custom spinners.
Co-authored-by: Garrick Aden-Buie <[email protected]>
9bf81b1 to
7c23967
Compare
gadenbuie
reviewed
May 10, 2024
f8650e9 to
ecedeea
Compare
cpsievert
added a commit
that referenced
this pull request
Jul 24, 2024
cpsievert
added a commit
that referenced
this pull request
Jul 24, 2024
cpsievert
added a commit
that referenced
this pull request
Jul 24, 2024
…fade` (#4104) * Follow up to #4040: enable busy indicators by default * Make our spinner invisible when wrapped inside a shinycssloaders::withSpinner() container * Add the ability to disable/customize recalculating opacity (i.e., fade) * Fix bug with fade not being applied correctly when the output container has no children * `devtools::document()` (GitHub Actions) * `yarn build` (GitHub Actions) * Update NEWS.md * Follow up to b7e7af: need to also rest opacity for :empty case (for initial calculation) * Rd docs fixes/improvements --------- Co-authored-by: cpsievert <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bring busy indication to Shiny. Busy indicators provide a visual cue to users when the server is busy calculating outputs or otherwise serving requests to the client. When enabled, a spinner is shown on each
calculating/recalculating output, and a pulsing banner is shown at the top of the page when the app is otherwise busy. Busy indicators will be enabled by default for UI created with
{bslib}(rstudio/bslib#1053), but must be enabled otherwise. To enable/disable, include the result ofuseBusyIndicators()in anywhere in the app's UI.Here is an illustration of the default spinner and pulse experience:
busy.mp4
App code
This PR also adds
busyIndicatorOptions()to customize the appearance of both spinners and the pulse. Here's an example showing off 4 of the mainspinner_types available:ring,bars,dots, andpulse.spinner-types.mp4
App code
TODO