Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Enable busy indicators by default, add ability to disable/customize fade#4104

Merged
cpsievert merged 9 commits intomainfrom
busy-indicators-by-default
Jul 24, 2024
Merged

Enable busy indicators by default, add ability to disable/customize fade#4104
cpsievert merged 9 commits intomainfrom
busy-indicators-by-default

Conversation

@cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jul 24, 2024

This PR does 4 things, reflected in each of the 1st 4 commits:

  1. [a899516]: Enables busy indicators by default. See Add busy indication #4040 (where busy indication was first added) for motivating examples.
  2. [c0de23d]: Makes Shiny's spinner effectively invisible when it appears inside shinycssloaders::withSpinner().
  3. [63b7864]: Adds the ability to disable/customize recalculating opacity (i.e., useBusyIndicators(fade = FALSE) or busyIndicatorOptions(fade_opacity = 1, fade_selector = ".plotly")).
  4. [b7e7af1]: Fixed a bug that already existed with fade not be applied correctly to outputs with no children when spinners are enabled (see With Bootstrap 5, uiOutput() doesn't dim in opacity when recalculating #4027 for a reprex of the issue).

@cpsievert cpsievert requested a review from gadenbuie July 24, 2024 15:32
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@cpsievert cpsievert merged commit 3f4676d into main Jul 24, 2024
@cpsievert cpsievert deleted the busy-indicators-by-default branch July 24, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants