Fix reports test failing due to date range on month change#431
Merged
apoorv-mishra merged 1 commit intodevelopfrom Jun 1, 2022
Merged
Fix reports test failing due to date range on month change#431apoorv-mishra merged 1 commit intodevelopfrom
apoorv-mishra merged 1 commit intodevelopfrom
Conversation
apoorv-mishra
pushed a commit
that referenced
this pull request
Jun 1, 2022
apoorv-mishra
pushed a commit
that referenced
this pull request
Jun 1, 2022
apoorv-mishra
pushed a commit
that referenced
this pull request
Jun 2, 2022
* Enable stripe connect in invoice settings * Remove option for ach bank transfer * Add model PaymentsProvider and corresponding specs * Add unique index on (name, company_id) * Fix typo and associated specs * Add routes * Implement controller actions * Add specs for GET /internal_api/v1/payments/providers * Add specs for POST /internal_api/v1/payments/providers * Add specs for PATCH /internal_api/v1/payments/providers/:id * Fix db/schema.rb * Integrate provider settings in FE * Fix specs * Fix spec as per pr-#431 * Save default stripe settings after connected account is successfully created * Fix saving duplicate payment methods and prevent sending id in update call * Save default stripe settings if not saved after fetching providers in invoice settings * Remove save button, not required anymore * Reorder controller actions * Remove unused code * Fix component name * Remove unused auto-gen files
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
vipulnsward
pushed a commit
that referenced
this pull request
Feb 15, 2026
* Enable stripe connect in invoice settings * Remove option for ach bank transfer * Add model PaymentsProvider and corresponding specs * Add unique index on (name, company_id) * Fix typo and associated specs * Add routes * Implement controller actions * Add specs for GET /internal_api/v1/payments/providers * Add specs for POST /internal_api/v1/payments/providers * Add specs for PATCH /internal_api/v1/payments/providers/:id * Fix db/schema.rb * Integrate provider settings in FE * Fix specs * Fix spec as per pr-#431 * Save default stripe settings after connected account is successfully created * Fix saving duplicate payment methods and prevent sending id in update call * Save default stripe settings if not saved after fetching providers in invoice settings * Remove save button, not required anymore * Reorder controller actions * Remove unused code * Fix component name * Remove unused auto-gen files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion card
Summary
Test creates one timesheet entry with date as starting of this week and causes issue when new month starts and week overlaps over the month.
Preview
Type of change
Please delete options that are not relevant.
not work as expected)
How Has This Been Tested?
Checklist: