Codestin Search App

apoorv-mishra · 2022-05-20T16:22:45Z

Notion card

https://saeloun.notion.site/Setting-on-invoice-for-payment-Backend-8c6fc57d900f4110b4a971cc6364ed55

Summary

Preview

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to
not work as expected)
This change requires a documentation update

How Has This Been Tested?

Checklist:

I have manually tested all workflows
I have performed a self-review of my own code
I have added automated tests for my code

github-actions · 2022-05-20T16:26:40Z

Current Code Coverage Percent of this PR:

84.55 %

Files having coverage below 100%

Impacted Files	Coverage
/app/controllers/subscriptions_controller.rb	66.67 %
/app/controllers/invoices_controller.rb	57.14 %
/app/models/invoice.rb	96.3 %
/app/policies/timezone_policy.rb	66.67 %
/app/policies/subscriptions_policy.rb	66.67 %
/app/policies/client_policy.rb	95.45 %
/app/policies/invoice_policy.rb	94.12 %
/app/controllers/invoices/payments_controller.rb	61.11 %
/app/services/report/filters.rb	87.88 %
/app/services/invoice_payment/checkout.rb	44.0 %
/app/services/invoice_payment/pdf_generation.rb	70.97 %
/app/controllers/internal_api/v1/timezones_controller.rb	37.5 %
/app/controllers/internal_api/v1/payment_settings_controller.rb	93.33 %
/app/controllers/internal_api/v1/clients_controller.rb	94.44 %
/app/controllers/internal_api/v1/invoices_controller.rb	94.87 %
/app/controllers/internal_api/v1/payments/providers_controller.rb	95.45 %
/lib/benchmarking/benchmarker.rb	0.0 %
/lib/countries_info.rb	0.0 %

vipulnsward · 2022-05-23T17:35:45Z

@apoorv-mishra what is pending on this? Need this so we can accept client payments. Freshbooks costs us 600$ per month

apoorv-mishra · 2022-05-24T04:58:14Z

Stripe connect and checkout is already integrated. We should already be able to receive payments. This PR is particularly for invoice settings to enable different payment methods for the customers. If you check stripe dashboard, receivables through card payments are auto enabled for connected accounts.

akhilgkrishnan

Added some suggestions

app/helpers/internal_api/v1/payments/providers_helper.rb

akhilgkrishnan · 2022-06-01T05:55:32Z

app/controllers/internal_api/v1/payments/providers_controller.rb

+
+class InternalApi::V1::Payments::ProvidersController < ApplicationController
+  def create
+    authorize :create, policy_class: Payments::ProviderPolicy


why do we need to specify the action explicitly?

Any alternate ways to make it work? Because it fails without specifying the action.

app/controllers/internal_api/v1/payments/providers_controller.rb

akhilgkrishnan · 2022-06-01T05:58:16Z

app/javascript/src/common/CustomToggle.tsx

 import React from "react";

-const CustomToggle = ({ isChecked = false, setIsChecked, toggleCss, id }) => (
+const CustomToggle = ({ isChecked = false, setIsChecked, toggleCss, id, onToggle = () => {}}) => ( // eslint-disable-line


can you add the type checking?

Candidate for another PR. It's used in multiple places and may break existing flows. Keeping it as it is in this PR.

app/javascript/src/components/Invoices/Generate/Invoice_settings.tsx

spec/helpers/internal_api/v1/payments/providers_helper_spec.rb

akhilgkrishnan · 2022-06-01T06:16:57Z

app/javascript/src/components/Invoices/Generate/Invoice_settings.tsx

 /* eslint-disable @typescript-eslint/no-var-requires */
-import React, { useState } from "react";
+import React, { useState, useEffect } from "react";
+import { setAuthHeaders, registerIntercepts } from "apis/axios";


we can move this to RouteConfig.tsx so we dont have to set this on each component inside the invoice

It would be better if you could suggest how as well in a way that it doesn't break existing functionality.

The x-csrf-token is being set even after removing call to setAuthHeaders. Hence removing it altogether.

…created

… call

… invoice settings

rohitjoshixyz

LGTM

apoorv1316

LGTM

* Enable stripe connect in invoice settings * Remove option for ach bank transfer * Add model PaymentsProvider and corresponding specs * Add unique index on (name, company_id) * Fix typo and associated specs * Add routes * Implement controller actions * Add specs for GET /internal_api/v1/payments/providers * Add specs for POST /internal_api/v1/payments/providers * Add specs for PATCH /internal_api/v1/payments/providers/:id * Fix db/schema.rb * Integrate provider settings in FE * Fix specs * Fix spec as per pr-#431 * Save default stripe settings after connected account is successfully created * Fix saving duplicate payment methods and prevent sending id in update call * Save default stripe settings if not saved after fetching providers in invoice settings * Remove save button, not required anymore * Reorder controller actions * Remove unused code * Fix component name * Remove unused auto-gen files

pr-triage bot added the PR: draft label May 20, 2022

apoorv-mishra force-pushed the invoice-settings branch 5 times, most recently from c7f4446 to 5da9900 Compare June 1, 2022 05:12

apoorv-mishra marked this pull request as ready for review June 1, 2022 05:12

pr-triage bot added PR: unreviewed and removed PR: draft labels Jun 1, 2022

apoorv-mishra requested review from akhilgkrishnan and rohitjoshixyz June 1, 2022 05:49

akhilgkrishnan reviewed Jun 1, 2022

View reviewed changes

apoorv-mishra force-pushed the invoice-settings branch from 6bcd1b3 to 3b24196 Compare June 1, 2022 09:48

Apoorv Mishra added 13 commits June 1, 2022 19:00

Enable stripe connect in invoice settings

37167e0

Remove option for ach bank transfer

182ab30

Add model PaymentsProvider and corresponding specs

c6e0949

Add unique index on (name, company_id)

8fc3a3b

Fix typo and associated specs

08a48a7

Add routes

dace8eb

Implement controller actions

dabb43a

Add specs for GET /internal_api/v1/payments/providers

2d368e1

Add specs for POST /internal_api/v1/payments/providers

2e8cf8d

Add specs for PATCH /internal_api/v1/payments/providers/:id

88bfea8

Fix db/schema.rb

eacf378

Integrate provider settings in FE

0cd3723

Fix specs

2eea409

Apoorv Mishra added 3 commits June 1, 2022 19:00

Fix spec as per pr-#431

9ec1a7f

Save default stripe settings after connected account is successfully …

a7ed3bb

…created

Fix saving duplicate payment methods and prevent sending id in update…

e410a19

… call

apoorv-mishra force-pushed the invoice-settings branch from 3b24196 to e410a19 Compare June 1, 2022 13:33

Apoorv Mishra added 6 commits June 1, 2022 19:40

Save default stripe settings if not saved after fetching providers in…

f2dd717

… invoice settings

Remove save button, not required anymore

09d3c5e

Reorder controller actions

20f46ff

Remove unused code

67122a3

Fix component name

41ab35b

Remove unused auto-gen files

3050b3d

rohitjoshixyz reviewed Jun 2, 2022

View reviewed changes

rohitjoshixyz approved these changes Jun 2, 2022

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jun 2, 2022

apoorv-mishra requested a review from apoorv1316 June 2, 2022 06:33

apoorv1316 approved these changes Jun 2, 2022

View reviewed changes

apoorv-mishra merged commit 15548ff into develop Jun 2, 2022

apoorv-mishra deleted the invoice-settings branch June 2, 2022 11:07

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Jun 2, 2022

Conversation

apoorv-mishra commented May 20, 2022

Notion card

Summary

Preview

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

github-actions bot commented May 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Code Coverage Percent of this PR:

84.55 %

Files having coverage below 100%

Uh oh!

vipulnsward commented May 23, 2022

Uh oh!

apoorv-mishra commented May 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akhilgkrishnan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akhilgkrishnan Jun 1, 2022

Choose a reason for hiding this comment

Uh oh!

apoorv-mishra Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akhilgkrishnan Jun 1, 2022

Choose a reason for hiding this comment

Uh oh!

apoorv-mishra Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

akhilgkrishnan Jun 1, 2022

Choose a reason for hiding this comment

Uh oh!

apoorv-mishra Jun 2, 2022

Choose a reason for hiding this comment

Uh oh!

apoorv-mishra Jun 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohitjoshixyz left a comment

Choose a reason for hiding this comment

Uh oh!

apoorv1316 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented May 20, 2022 •

edited

Loading

apoorv-mishra commented May 24, 2022 •

edited

Loading

apoorv-mishra Jun 2, 2022 •

edited

Loading

apoorv-mishra Jun 2, 2022 •

edited

Loading

apoorv-mishra Jun 2, 2022 •

edited

Loading