ENH: ArchivePlotCurveItem Connection Status #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4db392b to
f818482
Compare
26d850a to
f818482
Compare
YektaY
approved these changes
Sep 4, 2024
eea44aa to
7e11323
Compare
YektaY
approved these changes
Sep 5, 2024
zdomke
added a commit
to zdomke/pydm
that referenced
this pull request
Sep 13, 2024
ffd2d69 to
7143407
Compare
jbellister-slac
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
connection_state_signalto the Archiver Plugin and makes use of it in theArchivePlotCurveItem. More details given below:Archiver Plugin will emit to the connection_state_signal when
a. The Archiver URL doesn't exist ( --> False)
b. The network request returns an error and/or data that isn't JSON formatted ( --> False)
c. The network request returns no error and data in JSON format ( --> True)
TimePlotCurveItemchange:a. Create a channel connection signal that is emitted in
connectionStateChangedb. In address setter, disconnect channel (if one exists) and connect the new channel
ArchiverPlotCurveItemchanges:a. Create a channel connection signal that is directly tied to the archive_channel connection signal
b. In address setter, disconnect archive_channel (if one exists) and connect the new archive_channel
c. In the address setter, prompt the PyDMArchivePlot to request archive data (needs to be done through the plot to get the time range)
In
PyDMArchiveTimePlot, fix an issue with the default timespan not being set properly inupdateXAxis