Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add proper types for dialog components #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nihgwu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add proper types for dialog components #626

nihgwu wants to merge 1 commit into from
+22 −3

Conversation

@nihgwu
Copy link

@nihgwu nihgwu commented Dec 18, 2025 •
edited
Loading

having issues with tsgo

$ tsgo --noEmit
../../node_modules/@ladle/react/typings-for-build/app/src/ui.tsx:65:7 - error TS2322: Type '{ isOpen: boolean; onDismiss: () => void; "data-testid": string; children: Element; }' is not assignable to type 'IntrinsicAttributes & RefAttributes<unknown>'.
  Property 'isOpen' does not exist on type 'IntrinsicAttributes & RefAttributes<unknown>'.

65       isOpen={isOpen}
         ~~~~~~

../../node_modules/@ladle/react/typings-for-build/app/src/ui.tsx:73:9 - error TS2322: Type '{ "aria-label": string; "data-testid": string; style: { maxWidth: string; }; children: Element[]; }' is not assignable to type 'IntrinsicAttributes & RefAttributes<unknown>'.
  Property 'style' does not exist on type 'IntrinsicAttributes & RefAttributes<unknown>'.

73         style={{ maxWidth }}
           ~~~~~


Found 2 errors in the same file, starting at: ../../node_modules/@ladle/react/typings-for-build/app/src/ui.tsx:65

error Command failed with exit code 2.

@nihgwu
fix: remove ts-ignore comments and add proper types for dialog compon…
6df1272 
…ents

- Add type definitions for DialogOverlay and DialogContent props
- Cast the raw dialog components to properly typed React.FC
- Remove @ts-ignore comments from Modal component
@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2025

⚠️ No Changeset found

Latest commit: 6df1272

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nihgwu nihgwu changed the title fix: remove ts-ignore comments and add proper types for dialog components fix: add proper types for dialog components Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@nihgwu