Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add proper types for dialog components #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nihgwu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add proper types for dialog components #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions packages/ladle/lib/app/src/ui.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,28 @@
import * as React from "react";
import { DialogOverlay, DialogContent } from "./dialog";
import {
DialogOverlay as RawDialogOverlay,
DialogContent as RawDialogContent,
} from "./dialog";
import { Close } from "./icons";

// Type definitions for the dialog components from the bundled @reach/dialog
interface DialogOverlayProps {
isOpen?: boolean;
onDismiss?: () => void;
children?: React.ReactNode;
"data-testid"?: string;
}

interface DialogContentProps {
"aria-label"?: string;
"data-testid"?: string;
style?: React.CSSProperties;
children?: React.ReactNode;
}

const DialogOverlay = RawDialogOverlay as React.FC<DialogOverlayProps>;
const DialogContent = RawDialogContent as React.FC<DialogContentProps>;

export const Button = ({
children,
onClick,
Expand Down Expand Up @@ -60,13 +81,11 @@ export const Modal = ({
maxWidth?: string;
}) => {
return (
//@ts-ignore
<DialogOverlay
isOpen={isOpen}
onDismiss={() => close()}
data-testid="ladle-dialog-overlay"
>
{/* @ts-ignore */}
<DialogContent
aria-label={label || "Modal"}
data-testid="ladle-dialog"
Expand Down
Loading