Greatly improve static path performance #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's amazing improvement! Thanks! 👍 |
|
Your PR is shipped on https://github.com/tbrand/router.cr/releases/tag/v0.2.6 🎉 |
|
When compiled with the The code I used to benchmark: tree = Radix::Tree(String).new
path = "/GET/path/"
hash = {
"/GET/path/" => "woot!",
"/GET/path/:id" => "other!",
"/POST/path/:id" => "other2!"
}
tree.add("/GET/path/", "woot!")
tree.add("/GET/path/:id", "other!")
tree.add("/POST/path/:id", "other2!")
Benchmark.ips do |x|
x.report("Radix Lookup") do
result = tree.find(path)
raise "error" unless result.payload == "woot!"
end
x.report("Hash Lookup") do
result = hash[path]
raise "error" unless result == "woot!"
end
end |
|
Amazing! 🎉 |
waghanza
pushed a commit
to the-benchmarker/web-frameworks
that referenced
this pull request
Nov 4, 2018
* update router.cr for improved performance See: tbrand/router.cr#29 * use crystal 0.27.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing luislavena/radix with a hash for static route lookup.
Radix tree with a mix of static and route params paths
A radix tree with only static routes was 2.3 times slower than the hash.
I also removed the call to
.upcasewhen parsing the request as the HTTP standard specifies that this should be case sensitive - as such all browsers will make the request in the required case already.