Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add back FAB actions for experimental post page #1713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 27, 2025
Merged

Add back FAB actions for experimental post page #1713

merged 4 commits into from
Feb 27, 2025

Conversation

@hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Feb 26, 2025 •
edited
Loading

Pull Request Description

This PR continues work on #1413 and resolves some of the core remaining issues (e.g., re-introducing FAB and comment search). More specifically, the following issues have been resolved:

  • Bring back FAB (both with combine comment navigator and separate FAB)
  • Bring back comment search and scrolling to search result
  • When you create a comment, it does get displayed immediately, but it's not highlighted.

With this PR, I've also removed the legacy post page and any widgets/functions related to it. The new post page will now be displayed by default! I'll likely merge this in a bit sooner to be able to daily this change and find any additional bugs or issues with the new post page.

Issue Being Fixed

Issue Number: #1413

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu marked this pull request as ready for review February 27, 2025 00:58
micahmo
micahmo approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 3046638 into develop Feb 27, 2025
1 check passed
@hjiangsu hjiangsu deleted the feat/experimental-post-page-fab branch February 27, 2025 16:10
@micahmo
Copy link
Member

micahmo commented Mar 4, 2025

@hjiangsu

Can this code be removed?

thunder/lib/shared/comment_navigator_fab.dart

Lines 157 to 162 in c95b490

if (widget.comments == null) {
// This is a placeholder to allow the previous post page to function correctly.
// TODO: Remove this logic when we deprecate the legacy post page
navigateUp();
return;
}

thunder/lib/shared/comment_navigator_fab.dart

Lines 221 to 226 in c95b490

if (widget.comments == null) {
// This is a placeholder to allow the previous post page to function correctly.
// TODO: Remove this logic when we deprecate the legacy post page
navigateDown();
return;
}

@hjiangsu
Copy link
Member Author

hjiangsu commented Mar 4, 2025

Can this code be removed?

Good catch! We should be able to remove those conditionals now

@hjiangsu hjiangsu mentioned this pull request Mar 5, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micahmo micahmo micahmo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjiangsu @micahmo