Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Mar 5, 2025

Pull Request Description

This PR fixes an issue where attempting to navigate to a post from the Report page would cause a null check error because PostViewMedia was not provided. To fix this, the navigateToPost function has been modified to fetch the corresponding post if postViewMedia is null.

This is likely a regression from #1713 where the legacy post page was removed.

Additionally, I've removed the conditionals mentioned in #1713 here too!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

The issue:

issue.webm

Fixed:

fixed.webm

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit ad7e18e into develop Mar 5, 2025
1 check passed
@hjiangsu hjiangsu deleted the fix/report-page-post branch March 5, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants