Update the nRF I2C #2612
Merged
Update the nRF I2C #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alistair Francis <[email protected]>
Currently the capsule will double enter a grant. Let's fix that by avoiding entering a grant we have already entered. While fixing the code let's also return errors to userspace if the I2C operation fails. Signed-off-by: Alistair Francis <[email protected]>
hudson-ayers
approved these changes
Jun 7, 2021
2 tasks
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 21, 2021
2619: Add I2C slave support for nRF r=bradjc a=alistair23 ### Pull Request Overview This builds on top of #2612 by adding nRF I2C `master_slave_driver` support. ### Testing Strategy Running I2C communication on the nRF ### TODO or Help Wanted Nothing ### Documentation Updated - [X] Updated the relevant files in `/docs`, or no updates are required. ### Formatting - [X] Ran `make prepush`. Co-authored-by: Alistair Francis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This PR gets I2C working on the nRF52840DK. This also fixes Tock 2.0 issues in general for I2C.
Testing Strategy
I2C communication on the nRF52840DK
TODO or Help Wanted
Documentation Updated
/docs, or no updates are required.Formatting
make prepush.