Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@alistair23
Copy link
Contributor

Pull Request Overview

This builds on top of #2612 by adding nRF I2C master_slave_driver support.

Testing Strategy

Running I2C communication on the nRF

TODO or Help Wanted

Nothing

Documentation Updated

  • Updated the relevant files in /docs, or no updates are required.

Formatting

  • Ran make prepush.

@github-actions github-actions bot added the chips/nrf Change pertains to the nRF5x family of MCUs. label Jun 10, 2021
@alistair23 alistair23 force-pushed the alistair/i2c-2 branch 2 times, most recently from a5d5bb5 to 9f77941 Compare June 14, 2021 07:37
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though one question about a buffer change in capsules

bors bot added a commit to tock/libtock-c that referenced this pull request Jun 16, 2021
214: libtock/i2c_master_slave: Add ReadOnly buffer support r=ppannuto a=alistair23

This requires tock/tock#2619

Signed-off-by: Alistair Francis <[email protected]>

Co-authored-by: Alistair Francis <[email protected]>
@alistair23
Copy link
Contributor Author

This is ready to go

@hudson-ayers hudson-ayers added the last-call Final review period for a pull request. label Jun 18, 2021
@bradjc
Copy link
Contributor

bradjc commented Jun 21, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 21, 2021

@bors bors bot merged commit e3ecf4c into tock:master Jun 21, 2021
@alistair23 alistair23 deleted the alistair/i2c-2 branch June 21, 2021 22:12
bors bot added a commit to tock/libtock-c that referenced this pull request Jun 23, 2021
214: libtock/i2c_master_slave: Add ReadOnly buffer support r=alistair23 a=alistair23

This requires tock/tock#2619

Signed-off-by: Alistair Francis <[email protected]>

Co-authored-by: Alistair Francis <[email protected]>
tyler-potyondy pushed a commit to tyler-potyondy/libtock-c that referenced this pull request Mar 13, 2024
214: libtock/i2c_master_slave: Add ReadOnly buffer support r=alistair23 a=alistair23

This requires tock/tock#2619

Signed-off-by: Alistair Francis <[email protected]>

Co-authored-by: Alistair Francis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chips/nrf Change pertains to the nRF5x family of MCUs. last-call Final review period for a pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants