Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add publish package #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rpechuk wants to merge 49 commits into
base: main
Choose a base branch
from
Open

feat: Add publish package #682

rpechuk wants to merge 49 commits into from

Conversation

@rpechuk
Copy link
Collaborator

@rpechuk rpechuk commented Feb 9, 2025 •
edited
Loading

This PR contains and MVP for the new Publish CLI tool that will be used to transform YAML/JSON specs into shippable visualizations.

Current Changes:

  • Added mosaic-publish CLI tool for compiling and optimizing specs, handling data export, interactivity, and optimizations.

TODOs:

  • Add more user control over optimization params/streamline current user control (selective dataset inclusion, DuckDB export settings, granular optimization flags, etc.).
  • Refactor duplicated logic between MosaicClient and new base classes. Namely combine both base classes into one base class that discribes any activatable client. (See feat: consolidated activatable logic to core #683)
    • Open Question: Where should this be created since these span multiple packages
  • Expand README and add tests for CLI and utilities
  • Add further optimization and improve upon current optimizations:
    • Namely work on better pre-rendering + hydration
    • Automatic Tiling implementation
    • Cache hydration
    • Smart spec re-writing
    • etc.

Open Questions:

  • How should we handle interactive pre-rendered visualizations before data is loaded?
  • Are there any better/other output formats we should support?
  • Is the current way of handling dependencies correct (w/o relative reference to package and instead using npm version)?

@rpechuk rpechuk requested a review from jheer February 9, 2025 21:07
@rpechuk rpechuk changed the base branch from main to ron/activatable-interface February 9, 2025 21:24
rpechuk and others added 11 commits February 9, 2025 13:25
@rpechuk
Merge branch 'ron/activatable-interface' into ron/mosaic-publish
97c3c6e
@rpechuk
fix: implement Activatable interface for inputs and interactors
a2d1a18
@rpechuk
Merge branch 'ron/activatable-interface' of https://github.com/uwdata…
db3a4b3 
…/mosaic into ron/mosaic-publish
@rpechuk
fix: change Activatable to interface and remove ActivatableClient
7a13cf7
@rpechuk
fix: Changed intteractors to use new Activatable interface
a50afba
@rpechuk
Merge branch 'ron/activatable-interface' of https://github.com/uwdata…
b9b11ac 
…/mosaic into ron/mosaic-publish
@rpechuk
fix: update to use new isActivatable duck typing method
0730ad2
@rpechuk
fix: Add typedef to fix JSDoc import with implements errors
394563e
@rpechuk
Merge branch 'ron/activatable-interface' of https://github.com/uwdata…
6ba5556 
…/mosaic into ron/mosaic-publish
@rpechuk
chore: address and remove TODOs
f423519
@rpechuk
fix: Change core type export to index-types.ts pattern
5060a19
Base automatically changed from ron/activatable-interface to main February 13, 2025 18:33
@rpechuk rpechuk marked this pull request as ready for review February 17, 2025 00:43
@rpechuk rpechuk changed the base branch from main to ron/ast-to-dom-typing February 21, 2025 03:37
@rpechuk rpechuk mentioned this pull request Feb 21, 2025
Merged
Base automatically changed from ron/ast-to-dom-typing to v0.13.0 February 28, 2025 23:48
Base automatically changed from v0.13.0 to main March 1, 2025 00:22
@rpechuk rpechuk mentioned this pull request Mar 3, 2025
Merged
@rpechuk
Copy link
Collaborator Author

rpechuk commented Mar 3, 2025

Following up on #705 does it make sense to move away from CDN imports in published visualization code to avoid having to cut a release of other packages for a publish package release?

IMO, this has both benifts and downsides so maybe it makes sense to allow end user to choose and parametrize available optimizations based on user choice and available functionality.

rpechuk and others added 20 commits March 10, 2025 19:47
@rpechuk
feat: Add cache exporting and hydration capabilities (#705)
81e069a 
* feat: add typing and import/export to caches

* feat: add type propogation jsDocs

* feat: add cache publishing

* fix: change exporting to export Map

* fix: remove unnecessary params
@rpechuk
feat: add rollup to not be dependent on cdn
600c702
@rpechuk
Merge branch 'main' of https://github.com/uwdata/mosaic into ron/mosa…
4bb3102 
…ic-publish
@rpechuk
fix: remove dependence on fields method
c580394
@rpechuk
fix: handle undefinied
9260640
@rpechuk
fix: cache exporting
218e8e8
@rpechuk
feat: add more fine-grain control over optimizations
58bf43c
@rpechuk
feat: changes for VIS short paper
f1e583a
@rpechuk
Merge branch 'main' of https://github.com/uwdata/mosaic into ron/mosa…
213971c 
…ic-publish
@rpechuk
fix: build path + tsc errors
182fbf1
@rpechuk
fix: change binary path in tests
ce0772d
@rpechuk
feat: add further fine-grained control via CLI options
428084b
@rpechuk
Merge branch 'main' of https://github.com/uwdata/mosaic into ron/mosa…
694dfdf 
…ic-publish
@rpechuk
fix: update tests
d17fbba
@rpechuk
fix: increase timeout 10sec
86faf50
@rpechuk
fix: change to non-deprecated timeout adjustment
c13f464
@rpechuk
feat: update README with new usage
52b2a58
@rpechuk
feat: update README with new usage
f921a9f
@rpechuk
fix: update README to include experimental warning
4a58f80
@rpechuk @jheer
feat: Create ClauseSource interface and add book keeping to `Coordi…
6f5ca44 
…nator` for clause sources (#772)

* feat: change Activatable interface to ClauseSource interface

* feat: add clause source bookkeeping in coordinator

* fix: handle undefined clauseSources

* fix: remove selection reset from clause source reset fn

* feat: add clause source registration to coordinator

* fix: update typing on clause function + finish updating reset functions

* Simplify code in Interval2D.js

* Simplify code in Nearest.js

* Simplify code in PanZoom.js

* Simplify code in Region.js

* Simplify code in Toggle.js

* fix: move registration to constructor + add no arg clause functionality

* fix: update panzoom clause to throw error on improper usage

---------

Co-authored-by: Jeffrey Heer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jheer jheer Awaiting requested review from jheer jheer is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rpechuk