feat: consolidated activatable logic to core #683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheer
requested changes
Feb 10, 2025
Member
jheer
left a comment
There was a problem hiding this comment.
Looks good overall, but see comments for requested changes regarding use of types (TS vs. JS) and also what the table input is doing.
domoritz
reviewed
Feb 10, 2025
jheer
requested changes
Feb 13, 2025
Member
jheer
left a comment
There was a problem hiding this comment.
Looking good! Just a few remaining minor suggestions and a question to address.
jheer
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Activatableinterface tomosaic-coretypes, requires anactivate()method for selection activation.isActivatabletype check method tomosaic-core.Menu,Search,Slider,Table) to implement theActivatableinterface.Activatableinterface.mosaic-core.