(COV-816): feat/missingDataFiltersFlag: add missing data flag for inclusion in filters #119
Conversation
| if (config.esConfig.aggregationIncludeMissingData && !isNumericField) { | ||
| if (config.esConfig.aggregationIncludeMissingData | ||
| && !isNumericField | ||
| && config.esConfig.missingDataInFilters) { |
There was a problem hiding this comment.
why put this in backend? how is this logic different with just using aggregationIncludeMissingData?
if you put missingDataInFilters as false in here, it is essentially the same as using aggregationIncludeMissingData = false isn't it? and the charts will also has no missing data in the results returned from aggregation
There was a problem hiding this comment.
thanks, i was so excited to get things working i missed this
I got it working in src/components/ConnectedFilter/utils.js file, how would i read the config flags from this location? or do i need to set a variable in data portal and pass it down? is src/components/ConnectedFilter/utils.js the best location for this functionality?
|
starting over with #120 deleting this old branch |
Jira Ticket: COV-816
New Features