(COV-816): feat/missingDataFiltersFlag2: add missing data flag for inclusion in filters #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2021
mfshao
reviewed
Apr 19, 2021
Contributor
Author
|
Linked to uc-cdis/data-portal#837 this is where the filter flag is defined |
mfshao
reviewed
Apr 19, 2021
mfshao
approved these changes
Apr 20, 2021
Contributor
mfshao
left a comment
There was a problem hiding this comment.
code wise lgtm! thanks 🚀
is this deployed to qa-covid19? I didn't see it there
also don't forget to update package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: COV-816
New Features