feat: do not include _source field for aggregations #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
reviewed
Oct 26, 2021
| if (fields) { | ||
| const esFields = fromFieldsToSource(fields); | ||
| if (esFields.length > 0) queryBody._source = esFields; | ||
| if (fields !== undefined) { |
Contributor
There was a problem hiding this comment.
why don't do a single if (typeof fields !== 'undefined') and set queryBody._source = false; in its else clause?
Contributor
Author
There was a problem hiding this comment.
I think it'll break the backward compatibility, in case there is code that doesn't define fields, but still uses _source for something.
6ff96f9 to
ab0f175
Compare
jawadqur
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Breaking Changes
Bug Fixes
Improvements
_sourcefieldDependency updates
Deployment changes