-
Notifications
You must be signed in to change notification settings - Fork 119
Add CSRF Attack protection #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1f7b55e
to
0476cc3
Compare
@ueberauth/developers please share some code review on this one. cc: @jclem |
I will fix CI once the TODOs are solved (they are questions) |
Great work. |
@jclem since you reported the initial issue, would you like to take a peek at this code? |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 73.83% 75.57% +1.74%
==========================================
Files 4 4
Lines 107 131 +24
==========================================
+ Hits 79 99 +20
- Misses 28 32 +4
Continue to review full report at Codecov.
|
Co-authored-by: Sean Callan <[email protected]>
Please share some CR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doomspork yeah I will make another PR adding the proper changelog and version |
I think this looks good now. As soo n as we have a release we should properly to update one of the provider libs to make sure everything looks as intended |
closes #135