Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

yordis
Copy link
Member

@yordis yordis commented Mar 7, 2021

closes #135

@yordis
Copy link
Member Author

yordis commented Mar 7, 2021

@ueberauth/developers please share some code review on this one.

cc: @jclem

@yordis yordis marked this pull request as ready for review March 7, 2021 03:18
@yordis yordis requested a review from a team as a code owner March 7, 2021 03:18
@yordis
Copy link
Member Author

yordis commented Mar 7, 2021

I will fix CI once the TODOs are solved (they are questions)

@Hanspagh
Copy link
Contributor

Great work.
I don't think the name csrf_attack is great since it make it sound you enable csrf_attacks. I would rather see it named something like csrf_protection, and ignore_csrf_protection

@doomspork
Copy link
Member

@jclem since you reported the initial issue, would you like to take a peek at this code?

@codecov-io
Copy link

codecov-io commented Apr 12, 2021

Codecov Report

Merging #136 (725c214) into master (4b8b1e9) will increase coverage by 1.74%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
+ Coverage   73.83%   75.57%   +1.74%     
==========================================
  Files           4        4              
  Lines         107      131      +24     
==========================================
+ Hits           79       99      +20     
- Misses         28       32       +4     
Impacted Files Coverage Δ
lib/ueberauth/strategies/helpers.ex 78.72% <20.00%> (-7.00%) ⬇️
lib/ueberauth/strategy.ex 96.29% <100.00%> (+8.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b8b1e9...725c214. Read the comment docs.

@yordis
Copy link
Member Author

yordis commented Apr 12, 2021

Please share some CR

@doomspork doomspork self-requested a review April 12, 2021 19:30
@doomspork doomspork dismissed their stale review April 12, 2021 19:31

Changes addressed

Copy link
Member

@doomspork doomspork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @yordis 🎉 I'll let @Hanspagh be the approval.

Do we want to bump the version et al in a separate PR?

@yordis
Copy link
Member Author

yordis commented Apr 12, 2021

@doomspork yeah I will make another PR adding the proper changelog and version

@Hanspagh
Copy link
Contributor

I think this looks good now. As soo n as we have a release we should properly to update one of the provider libs to make sure everything looks as intended

@yordis yordis merged commit 5c297f1 into master Apr 17, 2021
@yordis yordis deleted the yordis/fix-135 branch April 17, 2021 22:29
@nbw nbw mentioned this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prevent CSRF Using state Parameter

4 participants